Bug 435541 - Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber communications mode
Summary: Review Request: xfhell - GTK based Ham Radio application for the Hellschreibe...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-03-01 10:32 UTC by Robert 'Bob' Jensen
Modified: 2008-03-16 19:30 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-03-14 17:33:30 UTC
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Robert 'Bob' Jensen 2008-03-01 10:32:17 UTC
Spec URL: http://bjensen.fedorapeople.org/pkgs/hams/SPECS/xfhell.spec
SRPM URL: http://bjensen.fedorapeople.org/pkgs/hams/SRPMS/xfhell-1.4-2.fc9.src.rpm
Description: xfhell is a GTK+ application for the "fuzzy" digital amateur radio communication mode known as Hellschreiber. 

This package mock builds for Fedora 7, Fedora 8 and devel on i386 and x86_64. All resulting rpms are rpmlint clean.

Comment 1 Jeroen van Meeuwen 2008-03-01 11:47:02 UTC
Source http://5b4az.chronos.org.uk/pkg/hell/xfhell-1.3.tar.gz doesn't match with
the %{version} (xfhell-1.4)

Comment 2 Parag AN(पराग) 2008-03-01 12:01:19 UTC
unable verify sources as 1.4 is not available.

Source URL should be
http://5b4az.chronos.org.uk/pkg/hell/%{name}-%{version}.tar.gz



Comment 3 Parag AN(पराग) 2008-03-01 12:08:26 UTC
make changes. provides new SRPM. Will review then.

Comment 4 Robert 'Bob' Jensen 2008-03-01 18:50:41 UTC
Do NOT package when tired... sorry about that.

Spec URL: http://bjensen.fedorapeople.org/pkgs/hams/SPECS/xfhell.spec
SRPM URL: http://bjensen.fedorapeople.org/pkgs/hams/SRPMS/xfhell-1.4-3.fc9.src.rpm

Comment 5 Jeroen van Meeuwen 2008-03-02 16:49:58 UTC
RPM Lint: OK
Package name: OK
Spec file: OK
License: OK (GPLv2+)
Actual License: OK (GPLv2+ from source code)
%doc License: OK (COPYING file included)
Spec file language: OK
Spec file readable: OK
Upstream source vs. used tarball: OK (md5sum match after figuring out the exact
location of the upstream tarball)
Compile and Build:
 - F-7: OK
 - F-8: OK
 - rawhide: OK
 - EL-5: OK
 - koji scratch dist-f9: OK
Applicable Package Guidelines:
 - -debuginfo package: OK (~136K)
Locales: N/A
Shared libs: N/A
Relocatable: N/A
Directory and file ownership: OK
No duplicate files in %files: OK
File Permissions: OK
Macro usage: OK
Code vs. Content: OK
(Large) Documentation: OK
%doc affecting runtime: OK
Header files in -devel package: N/A
Static Libraries in -static package: N/A
pkgconfig Requires: N/A
Library files: N/A
Devel requires base package: N/A
.la libtool archives: N/A
Duplicate ownership of files/directories: OK
Remove BuildRoot: OK
UTF-8 filenames: OK

Please adjust Source0 location to
http://5b4az.chronos.org.uk/pkg/%{name}/%{name}-%{version}.tar.gz please

Comment 7 Parag AN(पराग) 2008-03-03 03:49:12 UTC
Review:
+ package builds in mock (rawhide i386).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=485859 
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
ecaf2a9a48478f45d56bffac35773a82  xfhell-1.4.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ Compiler flags are honoured correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Desktop file installed correctly.
+ a GUI app.

 SHOULD:
   Ask upstream to add license file in next upstream tarball release.

APPROVED.


Comment 8 Robert 'Bob' Jensen 2008-03-03 05:34:45 UTC
New Package CVS Request
=======================
Package Name: xfhell
Short Description: GTK based Ham Radio application for the Hellschreiber
communications mode
Owners: bjensen,sconklin
Branches: F-7 F-8
InitialCC: sindrepb
Cvsextras Commits: yes

Comment 9 Kevin Fenzi 2008-03-03 20:14:34 UTC
cvs done.

Comment 10 Parag AN(पराग) 2008-03-13 03:14:57 UTC
so is this package built on all requested brnaches?
If yes can we CLOSE this review?

Comment 11 Robert 'Bob' Jensen 2008-03-14 16:10:31 UTC
I requested cvs and got sidetracked, then forgot, I will build and close today.

Comment 12 Fedora Update System 2008-03-14 17:28:19 UTC
xfhell-1.4-4.fc8 has been submitted as an update for Fedora 8

Comment 13 Fedora Update System 2008-03-14 17:29:39 UTC
xfhell-1.4-4.fc7 has been submitted as an update for Fedora 7

Comment 14 Robert 'Bob' Jensen 2008-03-14 17:33:30 UTC
Thank you for the review and reminder.

Comment 15 Fedora Update System 2008-03-16 19:30:15 UTC
xfhell-1.4-4.fc7 has been pushed to the Fedora 7 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2008-03-16 19:30:20 UTC
xfhell-1.4-4.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.