Bug 438299

Summary: DDC fails on PowerBook
Product: [Fedora] Fedora Reporter: David Woodhouse <dwmw2>
Component: xorg-x11-drv-atiAssignee: Dave Airlie <airlied>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: low    
Version: rawhideCC: jonstanley, xgl-maint
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-04-18 06:02:05 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 439966    
Attachments:
Description Flags
Xorg.log from Fedora 8
none
Xorg.log from Fedora 9
none
Electra Xorg.log none

Description David Woodhouse 2008-03-20 09:39:28 UTC 
Fedora 8 correctly reported the panel on my shinybook:
(II) RADEON(0): I2C device "DVI_DDC:ddc2" registered at address 0xA0.
(II) RADEON(0): DDC Type: 2, Detected Monitor Type: 2
(II) RADEON(0): EDID data from the display on connector: Proprietary/LVDS
----------------------
(II) RADEON(0): Manufacturer: APP  Model: 9c2c  Serial#: 0
(II) RADEON(0): Year: 2003  Week: 1
(II) RADEON(0): EDID Version: 1.3
(II) RADEON(0): Digital Display Input
(II) RADEON(0): Max H-Image Size [cm]: horiz.: 37  vert.: 23
....

Fedora 9 (xorg-x11-drv-ati-6.8.0-3.fc9) doesn't:
(II) RADEON(0): Output: LVDS, Detected Monitor Type: 0
(II) RADEON(0): Detected non-DDC Monitor Type: 2
finished output detect: 0
Comment 1 David Woodhouse 2008-03-20 09:42:36 UTC 
Created attachment 298672 [details]
Xorg.log from Fedora 8
Comment 2 David Woodhouse 2008-03-20 09:43:06 UTC 
Created attachment 298673 [details]
Xorg.log from Fedora 9
Comment 3 David Woodhouse 2008-03-20 12:04:11 UTC 
Created attachment 298688 [details]
Electra Xorg.log

I see DDC failure on an NV card too...
Comment 4 David Woodhouse 2008-03-21 01:10:32 UTC 
The DDC failure on ATI goes away, along with the crash on my G5, when I change
RADEONGetBIOSInfo() to avoid allocating a buffer of 64KiB and then immediately
asking pci_device_read_rom() to read the 128KiB BIOS ROM into it.

Why is it that we don't allocate a buffer of size info->PciInfo->rom_size,
anyway? That seems to be commented out, and we allocate RADEON_VBIOS_SIZE
(64KiB) instead.
Comment 5 David Woodhouse 2008-03-21 01:23:46 UTC 
--- a/src/radeon_bios.c
+++ b/src/radeon_bios.c
@@ -74,8 +74,8 @@ Bool RADEONGetBIOSInfo(ScrnInfoPtr pScrn, xf86Int10InfoPtr 
pInt10)
     unsigned short dptr;
 
 #ifdef XSERVER_LIBPCIACCESS
-    //info->VBIOS = xalloc(info->PciInfo->rom_size);
-    info->VBIOS = xalloc(RADEON_VBIOS_SIZE);
+    info->VBIOS = xalloc(info->PciInfo->rom_size);
+    //    info->VBIOS = xalloc(RADEON_VBIOS_SIZE);
 #else
     info->VBIOS = xalloc(RADEON_VBIOS_SIZE);
 #endif
Comment 6 Jon Stanley 2008-04-17 01:03:17 UTC 
Has this made it into rawhide yet? (just reviewing the F9 blocker)
Comment 7 Dave Airlie 2008-04-18 06:02:05 UTC 
should be fixed in rawhide this patch is in at least.