Bug 439262
| Summary: | Review Request: swing-layout - needed for NetBeans Platform | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jaroslav Tulach <jtulach> |
| Component: | Package Review | Assignee: | Colin Walters <walters> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, kevin, notting, walters |
| Target Milestone: | --- | Flags: | walters:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-04-26 01:35:56 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 439265 | ||
|
Description
Jaroslav Tulach
2008-03-27 18:59:56 UTC
* Remove %mkrel * (minor) License: tag should be LGPLv2+ From: http://fedoraproject.org/wiki/PackagingDrafts/Java * Should Requires: jpackage-utils Let me know when a version with the %mkrel is posted. I meant "when a version with the %mkrel fixed is posted." OK, done. New version is available: Spec URL: http://www.xelfi.cz/download/dev/SRPMS/swing-layout.spec SRPM URL: http://www.xelfi.cz/download/dev/SRPMS/swing-layout-1.0.3-1.src.rpm OK, done. New version is available: Spec URL: http://www.xelfi.cz/download/dev/SRPMS/swing-layout.spec SRPM URL: http://www.xelfi.cz/download/dev/SRPMS/swing-layout-1.0.3-1.src.rpm Sorry, for some reason I wasn't on the CC list. I get this error trying to build: DEBUG util.py:250: No Package Found for java-rpmbuild Looking over the spec quickly: * BuildRequires: java-devel >= 1.6.0 This needs to be >= 1:1.6.0, see http://fedoraproject.org/wiki/Packaging/Java * Source: Should be a fully-qualified URL here. I'll do a full check once we get those things fixed. Taking this review. Spec URL: http://www.xelfi.cz/download/dev/SRPMS/swing-layout.spec SRPM URL: http://www.xelfi.cz/download/dev/SRPMS/swing-layout-1.0.3-2.src.rpm Ok, builds fine in mock. Some rpmlint errors to fix: swing-layout.src: E: no-cleaning-of-buildroot %clean swing-layout.src: W: no-%clean-section Going through a quick checklist: * Upstream source is clean of binaries * License looks right * Spec is consistent If you fix the %clean section, I'll say this package is ready to be imported. I've added the clean section to do something. Spec URL: http://www.xelfi.cz/download/dev/SRPMS/swing-layout.spec SRPM URL: http://www.xelfi.cz/download/dev/SRPMS/swing-layout-1.0.3-3.src.rpm Ok, looks good. You can now request the fedora-cvs? flag. New Package CVS Request ======================= Package Name: swing-layout Short Description: Swing Layout Extensions Owners: jtulach Branches: F-7 F-8 InitialCC: jtulach Cvsextras Commits: yes Setting the CVS ? flag. Jaroslav: Is this your first package? I don't see you in the sponsored cvsextras group, at least not with this address. What is your Fedora Account System name? See: http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored Yes, it is my first package for fedora and yes, I am quite confused with the submission process. I have created some account today, so please check the system now. Hi Jaroslav, Yep, it looks like your account is active. Now you can set the "fedora-cvs?" flag in this bugzilla entry, and that will request a module to be created in CVS. By the way, you should also get a F-9 branch now (add F-9 to the Branches: list). After that's done, you'll have a CVS module from which you can import your SRPM and then start making a build. http://fedoraproject.org/wiki/PackageMaintainers/Join#head-d6a6db5509ce8ac73b4a8306e59aa2eaaa6f30dc *** This bug has been marked as a duplicate of 433497 *** Thanks for hint, but I've just tried to change the fedora-cvs flag and this is the reply: You tried to grant fedora-cvs. Only an authorized user can make this change. Please press Back and try again. Jaroslav: I still don't see you in the cvsextras group. Take a look at: http://fedoraproject.org/wiki/PackageMaintainers/Join#head-a601c13b0950a89568deafa65f505b4b58ee869b (step 4 of that link) OK, apparently swing-layout is already in. |