Bug 439285
Summary: | Review Request: php-openid - The PHP OpenID Library | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ian Weller <ian> |
Component: | Package Review | Assignee: | Orion Poplawski <orion> |
Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, lemenkov, notting |
Target Milestone: | --- | Flags: | orion:
fedora-review-
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-07-05 07:26:17 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 439340 |
Description
Ian Weller
2008-03-27 21:23:32 UTC
Good: - rpmlint checks return nothing - package meets naming guidelines - package meets packaging guidelines - license (ASL 2.0) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream e8be2d48139b4faa45626661c329bdb2 php-openid-2.0.1.tar.bz2 e8be2d48139b4faa45626661c329bdb2 php-openid-2.0.1.tar.bz2.orig - package compiles on devel (x86) - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Questions: Why do you need to BR php-common? It appears to build fine without it. I realized this after I finished packaging... do I need to reupload the package to fedorapeople so you can see just that one fix or can I integrate it into CVS after you approve it? it does build just fine. there were more issues that i found myself... version 2.0.1-2. spec - http://ianweller.fedorapeople.org/SRPMS/php-openid/2.0.1-2/php-openid.spec srpm - http://ianweller.fedorapeople.org/SRPMS/php-openid/2.0.1-2/php-openid-2.0.1-2.fc8.src.rpm * Sat Mar 29 2008 Ian Weller <ianweller> 2.0.1-2 - Removed unnecessary BuildRequires - Added provides php-yadis, since it does - Put everything under an Auth directory in datadir/php, because otherwise the code wouldn't work Also, another issue that has come up: if this package were to pass review, it would supersede bug 227190 and bug 227191, two packages for OpenID and Yadis in PHP. I've contacted the packager about this, and I've looked at the review requests, and it seems like they shouldn't be provided under the php-pear name, since I can't find OpenID in pear, and Yadis is out of date compared to URL0 for this package. orion: are you still willing to review this? i noticed you set fedora-review to -. i don't usually see that, i usually see them leave it at ? when there's still fixable issues... Giving bug 227190 and bug 227191 some time. Please place review on hold. |