Bug 442280
| Summary: | Review Request: squirrel - high level imperative/OO programming language | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dan Horák <dan> |
| Component: | Package Review | Assignee: | Hans de Goede <hdegoede> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | hdegoede:
fedora-review+
dennis: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 2.2.1-1.fc8 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-06-03 07:33:28 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Dan Horák
2008-04-13 19:24:24 UTC
There are a couple of small changes that you should make to the spec:
* your build section does not make use of the SMP flags (see
Packaging/Guidelines#parallelmake); fixable by adding %{?_smp_mflags} to the
make line in %build
* preserving timestamps; partially fixable by adding INSTALL="install -p" to
the " %make install " line in %install; this will the timestamps for files
included in squirrel-devel and squirrel-debuginfo. A nice touch would be to use
"touch -r "in order to also preserve preserve the timestamps of the 3 files
modified via sed (in %prep)
* Each %files section should have a %defattr line
(wiki: Packaging/ReviewGuidelines)
Updated spec URL: http://fedora.danny.cz/squirrel.spec Updated SRPM URL: http://fedora.danny.cz/squirrel-2.2-2.fc9.src.rpm * Sun Apr 27 2008 Dan Horak <dan[at]danny.cz> 2.2-2 - enable parallel make - add missing %%defattr for subpackages - preserve timestamps Hmm, spec & SRPM url's don't seem to be valid. Do you still wish for this to be submitted to Fedora? Looks like my webhosting changed their setup, I will fix it later today or tomorrow. I'll review this. Full review done: SHOULD FIX ---------- * Use standard (and actually working, unlike the current) sf.net download url of: http://downloads.sourceforge.net/squirrel/squirrel_%{version}.stable.tar.gz * You currently give README HISTORY and COPYRIGHT the timestamp of the COMPILE for for HISTORY this is different from the original timestamp of HISTORY and in future upstream releases chances are good the timestamps differ even more. Instead you should make backups while sed-ing using sed -i.orig and then use the .orig files as source for restoring the timestamps. No blockers, approved! Thanks for the review. ad 1 - my mistake - the releases are squirrel_X.Y.stable.tar.gz and squirrel_X.Y.Z_stable.tar.gz (and the spec in fact originated in version 2.1.1) ad 2 - thanks for the hint New Package CVS Request ======================= Package Name: squirrel Short Description: High level imperative/OO programming language Owners: sharkcz Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes cvs done. squirrel-2.2.1-1.fc9 has been submitted as an update for Fedora 9 squirrel-2.2.1-1.fc8 has been submitted as an update for Fedora 8 squirrel-2.2.1-1.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. squirrel-2.2.1-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: squirrel New Branches: EL-5 Owners: sharkcz CVS Done |