Bug 442280 - Review Request: squirrel - high level imperative/OO programming language
Summary: Review Request: squirrel - high level imperative/OO programming language
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Hans de Goede
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-04-13 19:24 UTC by Dan Horák
Modified: 2008-11-25 16:52 UTC (History)
2 users (show)

Fixed In Version: 2.2.1-1.fc8
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-06-03 07:33:28 UTC
Type: ---
Embargoed:
hdegoede: fedora-review+
dennis: fedora-cvs+


Attachments (Terms of Use)

Description Dan Horák 2008-04-13 19:24:24 UTC
Spec URL: http://fedora.danny.cz/squirrel.spec
SRPM URL: http://fedora.danny.cz/squirrel-2.2-1.fc9.src.rpm

Description:
Squirrel is a high level imperative/OO programming language, designed
to be a powerful scripting tool that fits in the size, memory bandwidth,
and real-time requirements of applications like games.

output from rpmlint:
squirrel-devel.x86_64: W: no-dependency-on squirrel
  can be ignored as -devel depends on -libs

scratch build in Koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=564425

Comment 1 manuel wolfshant 2008-04-27 12:38:01 UTC
There are a couple of small changes that you should make to the spec:
* your build section does not make use of the SMP flags (see
Packaging/Guidelines#parallelmake); fixable by adding  %{?_smp_mflags} to the
make line in %build
* preserving timestamps; partially fixable by adding  INSTALL="install -p" to
the " %make install " line in %install; this will the timestamps for files
included in squirrel-devel and squirrel-debuginfo. A nice touch would be to use
"touch -r "in order to also preserve preserve the timestamps of the 3 files
modified via sed (in %prep)
* Each %files section should have a %defattr line
  (wiki: Packaging/ReviewGuidelines)


Comment 2 Dan Horák 2008-04-28 07:48:33 UTC
Updated spec URL: http://fedora.danny.cz/squirrel.spec
Updated SRPM URL: http://fedora.danny.cz/squirrel-2.2-2.fc9.src.rpm

* Sun Apr 27 2008 Dan Horak <dan[at]danny.cz> 2.2-2
- enable parallel make
- add missing %%defattr for subpackages
- preserve timestamps

Comment 3 Brian Pepple 2008-05-27 19:16:55 UTC
Hmm, spec & SRPM url's don't seem to be valid.  Do you still wish for this to be
submitted to Fedora?

Comment 4 Dan Horák 2008-05-28 05:58:43 UTC
Looks like my webhosting changed their setup, I will fix it later today or tomorrow.

Comment 5 Hans de Goede 2008-05-31 08:59:25 UTC
I'll review this.


Comment 6 Hans de Goede 2008-05-31 13:15:56 UTC
Full review done:

SHOULD FIX
----------
* Use standard (and actually working, unlike the current) sf.net download url of:
  http://downloads.sourceforge.net/squirrel/squirrel_%{version}.stable.tar.gz

* You currently give README HISTORY and COPYRIGHT the timestamp of the COMPILE for
  for HISTORY this is different from the original timestamp of HISTORY and in
  future upstream releases chances are good the timestamps differ even more.

  Instead you should make backups while sed-ing using sed -i.orig and then
  use the .orig files as source for restoring the timestamps.


No blockers, approved!


Comment 7 Dan Horák 2008-05-31 13:50:23 UTC
Thanks for the review.

ad 1 - my mistake - the releases are squirrel_X.Y.stable.tar.gz and
squirrel_X.Y.Z_stable.tar.gz (and the spec in fact originated in version 2.1.1)

ad 2 - thanks for the hint

Comment 8 Dan Horák 2008-05-31 13:52:48 UTC
New Package CVS Request
=======================
Package Name: squirrel
Short Description: High level imperative/OO programming language
Owners: sharkcz
Branches: F-8 F-9
InitialCC:
Cvsextras Commits: yes


Comment 9 Kevin Fenzi 2008-05-31 23:18:30 UTC
cvs done.

Comment 10 Fedora Update System 2008-06-01 09:39:41 UTC
squirrel-2.2.1-1.fc9 has been submitted as an update for Fedora 9

Comment 11 Fedora Update System 2008-06-01 09:40:23 UTC
squirrel-2.2.1-1.fc8 has been submitted as an update for Fedora 8

Comment 12 Fedora Update System 2008-06-03 07:33:25 UTC
squirrel-2.2.1-1.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2008-06-03 07:34:32 UTC
squirrel-2.2.1-1.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Dan Horák 2008-11-25 12:42:51 UTC
Package Change Request
======================
Package Name: squirrel
New Branches: EL-5
Owners: sharkcz

Comment 15 Dennis Gilmore 2008-11-25 16:52:35 UTC
CVS Done


Note You need to log in before you can comment on or make changes to this bug.