Bug 442873

Spec URL: http://www.annexia.org/tmp/ocaml/virt-df.spec
SRPM URL: http://www.annexia.org/tmp/ocaml/virt-df-2.0.2-1.fc9.src.rpm
* Thu May  1 2008 Richard W.M. Jones <rjones> - 2.0.2-1
- New upstream version 2.0.2.
- Don't depend on ocaml-gettext, it's not used at the moment.
- Don't gzip the manpage, it happens automagically.
- This version needs bitmatch >=  0.5.
- +BR ocaml-xml-light-devel
- +BR ocaml-camlp4-devel

Here's a Koji scratch build:

http://koji.fedoraproject.org/koji/taskinfo?taskID=591884

Spec URL: http://www.annexia.org/tmp/ocaml/virt-df.spec
SRPM URL: http://www.annexia.org/tmp/ocaml/virt-df-2.1.1-1.fc9.src.rpm

* Tue May 13 2008 Richard W.M. Jones <rjones> - 2.1.1-1
- New upstream version 2.1.1.
- Needs bitmatch >= 0.9.

Koji scratch build in dist-f10:
  http://koji.fedoraproject.org/koji/taskinfo?taskID=607745

Judging by bug 442871 this probably fails to build if ocaml-gettext is installed.
Setting it back to NEEDINFO of me to fix.

This version works with ocaml-gettext:

Spec URL: http://www.annexia.org/tmp/ocaml/virt-df.spec
SRPM URL: http://www.annexia.org/tmp/ocaml/virt-df-2.1.1-5.fc10.src.rpm
* Fri May 16 2008 Richard W.M. Jones <rjones> - 2.1.1-5
- Reenable ocaml-gettext-devel BR and get it working properly.
- Use find_lang to find PO files.
- +BR ocaml-fileutils-devel (not strictly needed, but a dependency
  of gettext).
- +BR ocaml-camomile-data except on ppc64.

Koji build:
  http://koji.fedoraproject.org/koji/taskinfo?taskID=612794

+ rpmlint output

Clean, according to bug submitter.

+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
? package should satisfy packaging guidelines
? license meets guidelines and is acceptable to Fedora
? license matches the actual package license
? %doc includes license file
? spec file written in American English
? spec file is legible
? upstream sources match sources in the srpm
? package successfully builds on at least one architecture
? ExcludeArch bugs filed
? BuildRequires list all build dependencies
? %find_lang instead of %{_datadir}/locale/*
? binary RPM with shared library files must call ldconfig in %post and %postun
? does not use Prefix: /usr
? package owns all directories it creates
? no duplicate files in %files
? %defattr line
? %clean contains rm -rf $RPM_BUILD_ROOT
? consistent use of macros
? package must contain code or permissible content
? large documentation files should go in -doc subpackage
? files marked %doc should not affect package
? header files should be in -devel
? static libraries should be in -static
? packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
? libfoo.so must go in -devel
? -devel must require the fully versioned base
? packages should not contain libtool .la files
? packages containing GUI apps must include %{name}.desktop file
? packages must not own files or directories owned by other packages
? %install must start with rm -rf %{buildroot} etc.
? filenames must be valid UTF-8

Optional:

? if there is no license file, packager should query upstream
? translations of description and summary for non-English languages, if available
? reviewer should build the package in mock
? the package should build into binary RPMs on all supported architectures
? review should test the package functions as described
? scriptlets should be sane
? pkgconfig files should go in -devel
? shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin

Sorry about that last comment....I meant to delete it, but I forgot.  I'll
update with a more complete review.

Chris Lalancette

When trying to build this package on F-9 with ocaml packages update to F-10, I
seem to be running into a build failure:

+ make depend
for d in lib virt-df diskzip; do \
          make -C $d depend; \
          if [ $? -ne 0 ]; then exit 1; fi; \
        done
make[1]: Entering directory `/usr/src/redhat/BUILD/virt-df-2.1.1/lib'
rm -f .depend
ocamlfind ocamldep -package unix,extlib -I +bitmatch -pp "camlp4o -I`ocamlc
-where`/bitmatch pa_bitmatch.cmo" diskimage_ext2.mli diskimage_fat.mli
diskimage_impl.mli diskimage_linux_swap.mli diskimage_linux_swsuspend.mli
diskimage_lvm2_metadata.mli diskimage_lvm2.mli diskimage_mbr.mli diskimage.mli
diskimage_ntfs.mli int63_on_32.mli int63_on_64.mli diskimage_ext2.ml
diskimage_fat.ml diskimage_impl.ml diskimage_linux_swap.ml
diskimage_linux_swsuspend.ml diskimage_lvm2_metadata.ml diskimage_lvm2.ml
diskimage_mbr.ml diskimage.ml diskimage_ntfs.ml int63_on_32.ml int63_on_64.ml
test_int63.ml > .depend
Camlp4: Uncaught exception: DynLoader.Error
("/usr/lib/ocaml/bitmatch/pa_bitmatch.cmo", "error while linking
/usr/lib/ocaml/bitmatch/pa_bitmatch.cmo.\nReference to undefined global `Bitmatch'")

(and then there are a bunch more build failures).  Rich points out that this
patch is probably needed:

http://hg.et.redhat.com/virt/applications/virt-df--devel?cs=00a35ad4c881

Chris Lalancette

Spec URL: http://www.annexia.org/tmp/ocaml/virt-df.spec
SRPM URL: http://www.annexia.org/tmp/ocaml/virt-df-2.1.1-6.fc10.src.rpm
* Sun May 18 2008 Richard W.M. Jones <rjones> - 2.1.1-6
- Include upstream cset 00a35ad4c881 which fixes build with
  latest bitmatch.

OK, review with updated package:

+ rpmlint output

Clean, according to bug submitter.

+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora
+ license matches the actual package license
+ %doc includes license file
+ spec file written in American English
+ spec file is legible
+ upstream sources match sources in the srpm
+ package successfully builds on at least one architecture
n/a ExcludeArch bugs filed
+ BuildRequires list all build dependencies
+ %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and %postun
+ does not use Prefix: /usr
+ package owns all directories it creates
+ no duplicate files in %files
+ %defattr line
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ consistent use of macros
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
+ files marked %doc should not affect package
n/a header files should be in -devel
n/a static libraries should be in -static
n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a -devel must require the fully versioned base
n/a packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
+ packages must not own files or directories owned by other packages
+ %install must start with rm -rf %{buildroot} etc.

It actually starts with rm -rf $RPM_BUILD_ROOT, but I believe that is valid as
part of the guidelines, and $RPM_BUILD_ROOT is used consistently throughout the
specfile.

+ filenames must be valid UTF-8

Optional:

+ if there is no license file, packager should query upstream
- translations of description and summary for non-English languages, if available

Translations of these don't seem to be available

- reviewer should build the package in mock
+ the package should build into binary RPMs on all supported architectures
- review should test the package functions as described
+ scriptlets should be sane
n/a pkgconfig files should go in -devel
+ shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin

This package looks fine.

APPROVED

Excellent news, thanks for looking at this Chris.

CVS request coming up ...

New Package CVS Request
=======================
Package Name: virt-df
Short Description: Utility like 'df' for virtual guests
Owners: rjones
Branches: F-8 F-9
InitialCC: rjones
Cvsextras Commits: yes

cvs done.

Built for Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=617922

F8/F9 have to wait until the latest ocaml-bitmatch is pushed to
stable.

Now built for F8/F9.