This is the familiar 'gettext' library for OCaml programs. The upstream version (0.2.0) doesn't work with the latest OCaml compiler, but I've supplied a large patch upstream which fixes all the problems and upstream have promised a new release containing this patch real soon (will be 0.3.0). I was waiting for this release, but I can't wait any longer, hence this is based on the old version (0.2.0) + my large patch. The library depends on ocaml-camomile but that doesn't build on ppc64 (bug 438486). Since Camomile is a huge dependency and not necessarily desirable (most people will want to use just the basic functionality which is implemented using C gettext), I've split that part off into a subpackage which doesn't get built on ppc64. Spec URL: http://www.annexia.org/tmp/ocaml/ocaml-gettext.spec SRPM URL: http://www.annexia.org/tmp/ocaml/ocaml-gettext-0.2.0-2rwmj20080321.fc9.src.rpm Description: OCaml library for i18n Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=570335
I'd be happy to review this... look for a full review in a bit.
See below - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (LGPLv2+ with exceptions) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 4e95d69e6910c4c0dcafb7e2f8dc5491 ocaml-gettext-0.2.0.tar.gz 4e95d69e6910c4c0dcafb7e2f8dc5491 ocaml-gettext-0.2.0.tar.gz.orig OK - Package needs ExcludeArch See below - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Headers/static libs in -devel subpackage. OK - .so files in -devel subpackage. OK - -devel package Requires: %{name} = %{version}-%{release} OK - Package compiles and builds on at least one arch. See below - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should have subpackages require base package with fully versioned depend. OK - Should have dist tag OK - Should package latest version Issues: 1. Whats with the odd release naming? If you need a snapshot release, see: http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-cfd71146dbb6f00cec9fe3623ea619f843394837 and http://fedoraproject.org/wiki/Packaging/SourceURL#head-615f6271efb394ab340a93a6cf030f2d08cf0d49 2. I see in the build output: checking for fop... no configure: WARNING: Cannot find fop." Missing buildrequires? 3. Looks like the camomile-devel and devel subpackages duplicate all the docs... That doesn't seem very ideal. %doc README CHANGELOG TODO build/share/doc/html/* on both of them. 4. rpmlint says: ocaml-gettext-camomile.x86_64: E: only-non-binary-in-usr-lib This can be ignored as you can't make just a subpackage noarch.
Thanks for looking at this. The story with naming is that I've patched this to work with OCaml 3.10 and contributed the patch upstream. Coincidentally the author blogged about this yesterday: http://le-gall.net/sylvain+violaine/blog/index.php?2008/04/24/43-ocaml-gettext-on-going-progress-to-version-030 BTW, I wouldn't believe that release date .. seen too many release dates come and go already, although it'd be nice if it happens. Anyway, I changed the naming to conform with guidelines. Fop - this is a saga: If enabled, it causes a giant Java backtrace / error, and there seems to be no way to disable just fop (I even tried patching aclocal.m4). So in the meantime I've disabled the documentation. Here's a new version that should fix everything: Spec URL: http://www.annexia.org/tmp/ocaml/ocaml-gettext.spec SRPM URL: http://www.annexia.org/tmp/ocaml/ocaml-gettext-0.2.0-3.20080321patch.fc9.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=584043
Excellent. That solves all the issues I see...so this package is APPROVED. You might wait a day or two to import on the chance that 0.3.0 comes out. ;)
Heh, I've been waiting for this one too long. Thanks for doing it.
New Package CVS Request ======================= Package Name: ocaml-gettext Short Description: OCaml library for i18n Owners: rjones Branches: F-8 F-9 InitialCC: rjones Cvsextras Commits: yes
Yeah, I have a interest in the virt-* tools and this is needed for the new ones you added for review. ;) cvs done.
devel: http://koji.fedoraproject.org/koji/taskinfo?taskID=585140 F-9: http://koji.fedoraproject.org/koji/taskinfo?taskID=585139 Not built for F-8 yet because I'm waiting for ocaml-camomile to work its way into stable.