Bug 443303
Summary: | Review Request: notification-daemon-engine-nodoka | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Martin Sourada <martin.sourada> |
Component: | Package Review | Assignee: | Matthias Clasen <mclasen> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting |
Target Milestone: | --- | Flags: | mclasen:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 0.1.0-2.fc9 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-05-21 11:00:45 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Martin Sourada
2008-04-20 13:14:15 UTC
Taking this. First note: due to defective libsexy requires, it needs a BuildRequires: libxml2-devel see bug 446842 With that fix, it builds fine, and rpmlint has nothing to complain in the generated packages. it seems to work fine, we just need to work out where to set the gconf key /apps/notification-daemon/theme to enable this by default. Formal review in a bit, when I get to the office. formal review: package name: ok spec file name: ok packaging guidelines: ok license: ok license field: ok license file: ok spec file language: ok spec file legible: extremely buildable: yes ExcludeArch: n/a upstream sources: ok BuildRequires: need to add libxml2-devel locale handling: n/a ldconfig: ok relocatable: n/a directory ownership: ok duplicate files: ok file permissions: ok %clean: ok macro use: consistent content: permissible large docs: n/a %doc: ok headers: ok static libs: ok pc files: ok shared libs: ok devel package: n/a la files: ok gui apps: ok directory ownership: ok %install: ok utf8 filenames: ok Summary, fix the BuildRequires, then it is fine. Thanks for pointing that out. Fixed: SPEC: http://mso.fedorapeople.org/packages/SPECS/notification-daemon-engine-nodoka.spec SPRM: http://mso.fedorapeople.org/packages/SRPMS/notification-daemon-engine-nodoka-0.1.0-2.fc9.src.rpm Approved. One thing we need to figure out is how to make sure that users get this theme. We can probably patch the default gconf value in notification-daemon for now, but longer-term it would be nicer if the metatheme spec had a field for notification themes, and the appearance capplet handled it (In reply to comment #6) > Approved. One thing we need to figure out is how to make sure that users get > this theme. We can probably patch the default gconf value in notification-daemon > for now, but longer-term it would be nicer if the metatheme spec had a field for > notification themes, and the appearance capplet handled it Yeah, that would be nice. I was playing with a thought of making a simple app for selecting notification-daemon engine, but having it in the appearance capplet (and metatheme) would be better. Perhaps would be good to consult it with the notification-daemon developer(s) as well :) New Package CVS Request ======================= Package Name: notification-daemon-engine-nodoka Short Description: Nodoka Notificaton Daemon Engine Owners: mso Branches: F-8, F-9 InitialCC: Cvsextras Commits: yes cvs done. notification-daemon-engine-nodoka-0.1.0-2.fc9 has been submitted as an update for Fedora 9 notification-daemon-engine-nodoka-0.1.0-2.fc8 has been submitted as an update for Fedora 8 It should be available in rawhide by now. Closing. notification-daemon-engine-nodoka-0.1.0-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. notification-daemon-engine-nodoka-0.1.0-2.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. |