Bug 443303

Summary: Review Request: notification-daemon-engine-nodoka
Product: [Fedora] Fedora Reporter: Martin Sourada <martin.sourada>
Component: Package ReviewAssignee: Matthias Clasen <mclasen>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting
Target Milestone: ---Flags: mclasen: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 0.1.0-2.fc9 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-05-21 11:00:45 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Martin Sourada 2008-04-20 13:14:15 UTC
Spec URL: http://mso.fedorapeople.org/packages/SPECS/notification-daemon-engine-nodoka.spec
SRPM URL: http://mso.fedorapeople.org/packages/SRPMS/notification-daemon-engine-nodoka-0.1.0-1.fc9.src.rpm
Description: The Nodoka theme engine/theme for the notification daemon

Additional info: I am also upstream for this package. To enable the engine (e.g. for testing purposes) one needs to set gconf key "/apps/notification-daemon/theme" to "nodoka".

Comment 1 Matthias Clasen 2008-05-16 12:20:38 UTC
Taking this. 

First note: due to defective libsexy requires, it needs a 

BuildRequires: libxml2-devel

see bug 446842

Comment 2 Matthias Clasen 2008-05-16 12:21:52 UTC
With that fix, it builds fine, and rpmlint has nothing to complain in the
generated packages.

Comment 3 Matthias Clasen 2008-05-16 12:27:05 UTC
it seems to work fine, we just need to work out where to set the gconf key
/apps/notification-daemon/theme to enable this by default.

Formal review in a bit, when I get to the office.

Comment 4 Matthias Clasen 2008-05-16 15:05:42 UTC
formal review:

package name: ok
spec file name: ok
packaging guidelines: ok
license: ok
license field: ok
license file: ok
spec file language: ok
spec file legible: extremely
buildable: yes
ExcludeArch: n/a
upstream sources: ok
BuildRequires: need to add libxml2-devel
locale handling: n/a
ldconfig: ok
relocatable: n/a
directory ownership: ok
duplicate files: ok
file permissions: ok
%clean: ok
macro use: consistent
content: permissible
large docs: n/a
%doc: ok
headers: ok
static libs: ok
pc files: ok
shared libs: ok
devel package: n/a
la files: ok
gui apps: ok
directory ownership: ok
%install: ok
utf8 filenames: ok


Summary, fix the BuildRequires, then it is fine. 

Comment 6 Matthias Clasen 2008-05-16 18:11:02 UTC
Approved. One thing we need to figure out is how to make sure that users get
this theme. We can probably patch the default gconf value in notification-daemon
for now, but longer-term it would be nicer if the metatheme spec had a field for
notification themes, and the appearance capplet handled it

Comment 7 Martin Sourada 2008-05-16 22:17:12 UTC
(In reply to comment #6)
> Approved. One thing we need to figure out is how to make sure that users get
> this theme. We can probably patch the default gconf value in notification-daemon
> for now, but longer-term it would be nicer if the metatheme spec had a field for
> notification themes, and the appearance capplet handled it

Yeah, that would be nice. I was playing with a thought of making a simple app
for selecting notification-daemon engine, but having it in the appearance
capplet (and metatheme) would be better. Perhaps would be good to consult it
with the notification-daemon developer(s) as well :)

Comment 8 Martin Sourada 2008-05-16 22:21:58 UTC
New Package CVS Request
=======================
Package Name: notification-daemon-engine-nodoka
Short Description: Nodoka Notificaton Daemon Engine
Owners: mso
Branches: F-8, F-9
InitialCC: 
Cvsextras Commits: yes


Comment 9 Kevin Fenzi 2008-05-17 20:35:36 UTC
cvs done.

Comment 10 Fedora Update System 2008-05-17 23:28:31 UTC
notification-daemon-engine-nodoka-0.1.0-2.fc9 has been submitted as an update for Fedora 9

Comment 11 Fedora Update System 2008-05-17 23:31:04 UTC
notification-daemon-engine-nodoka-0.1.0-2.fc8 has been submitted as an update for Fedora 8

Comment 12 Martin Sourada 2008-05-20 13:44:17 UTC
It should be available in rawhide by now. Closing.

Comment 13 Fedora Update System 2008-05-21 11:00:43 UTC
notification-daemon-engine-nodoka-0.1.0-2.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2008-06-03 07:33:42 UTC
notification-daemon-engine-nodoka-0.1.0-2.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.