Bug 443588
| Summary: | Review Request: fig2sxd - fig to sxd converter | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Paul F. Johnson <paul> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | rc040203:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-07-08 18:01:39 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Paul F. Johnson
2008-04-22 12:51:13 UTC
Package doesn't build: * Missing deps: ... In file included from zipwrite.cpp:21 : zipwrite.h:29:18: error: zlib.h: No such file or directory ... Likely a missing dep on zlib-devel. * Package doesn't honor RPM_OPT_FLAGS: .... g++ -Wall -W -O2 -g -o fig2sxd.o -c fig2sxd.cpp g++ -Wall -W -O2 -g -o xfig_arc.o -c xfig_arc.cpp Ping? Sorry - been working on a few other things as well. I've fixed the zlib-devel requirement, but the makefile isn't a standard GNU makefile so passing RPM_OPT_FLAGS isn't making a difference. I'm talking upstream to see if the author will fix this or if I have to. Spec URL: http://pfj.fedorapeople.org/fig2sxd.spec SRPM URL: http://pfj.fedorapeople.org/fig2sxd-0.17-2.fc9.src.rpm Fixed the makefile not honouring $(CFLAGS) as well as the zlib-devel bit. Spec URL: http://pfj.fedorapeople.org/fig2sxd.spec SRPM URL: http://pfj.fedorapeople.org/fig2sxd-0.18-1.fc10.src.rpm Includes a fix for the padding problem APPROVED, provided you fix one outstanding MUSTFIX: * Change Source0 into a downloads.sourceforge.net-rooted URL, similar to this: http://downloads.sourceforge.net/%{name}/%{name}_%{version}.orig.tar.gz Fixed :-) New Package CVS Request ======================= Package Name: fig2sxd Short Description: Converts fig files to sxd (OpenOffice) Owners: pfj Branches: f8, f9, rawhide InitialCC: Cvsextras Commits: yes cvs done. |