Bug 443588 - Review Request: fig2sxd - fig to sxd converter
Review Request: fig2sxd - fig to sxd converter
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-04-22 08:51 EDT by Paul F. Johnson
Modified: 2008-07-08 14:01 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-07-08 14:01:39 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
rc040203: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Paul F. Johnson 2008-04-22 08:51:13 EDT
Spec URL: http://pfj.fedorapeople.org/fig2sxd.spec
SRPM URL: http://pfj.fedorapeople.org/fig2sxd-0.17-1.fc9.src.rpm
Description: fig2sxd is a converter from fig to OpenOffice sxd formats. It can be used by itself or as a plugin for chemtool (automatically detected when chemtool starts up)
Comment 1 Ralf Corsepius 2008-04-25 09:57:50 EDT
Package doesn't build:
* Missing deps:
...
In file included from zipwrite.cpp:21
: zipwrite.h:29:18: error: zlib.h: No such file or directory  
...
Likely a missing dep on zlib-devel.


* Package doesn't honor RPM_OPT_FLAGS:
....
g++ -Wall -W -O2 -g  -o fig2sxd.o -c fig2sxd.cpp  
g++ -Wall -W -O2 -g  -o xfig_arc.o -c xfig_arc.cpp
Comment 2 Ralf Corsepius 2008-05-10 02:20:04 EDT
Ping? 
Comment 3 Paul F. Johnson 2008-05-13 03:57:25 EDT
Sorry - been working on a few other things as well. I've fixed the zlib-devel
requirement, but the makefile isn't a standard GNU makefile so passing
RPM_OPT_FLAGS isn't making a difference.

I'm talking upstream to see if the author will fix this or if I have to.
Comment 4 Paul F. Johnson 2008-05-13 08:36:05 EDT
Spec URL: http://pfj.fedorapeople.org/fig2sxd.spec
SRPM URL: http://pfj.fedorapeople.org/fig2sxd-0.17-2.fc9.src.rpm

Fixed the makefile not honouring $(CFLAGS) as well as the zlib-devel bit.
Comment 5 Paul F. Johnson 2008-05-19 05:09:21 EDT
Spec URL: http://pfj.fedorapeople.org/fig2sxd.spec
SRPM URL: http://pfj.fedorapeople.org/fig2sxd-0.18-1.fc10.src.rpm

Includes a fix for the padding problem
Comment 6 Ralf Corsepius 2008-05-20 06:36:22 EDT
APPROVED, provided you fix one outstanding MUSTFIX:

* Change Source0 into a downloads.sourceforge.net-rooted URL, similar to this:
http://downloads.sourceforge.net/%{name}/%{name}_%{version}.orig.tar.gz
Comment 7 Paul F. Johnson 2008-05-20 07:15:33 EDT
Fixed :-)

New Package CVS Request
=======================
Package Name: fig2sxd
Short Description: Converts fig files to sxd (OpenOffice)
Owners: pfj
Branches: f8, f9, rawhide
InitialCC: 
Cvsextras Commits: yes
Comment 8 Kevin Fenzi 2008-05-20 12:03:58 EDT
cvs done.

Note You need to log in before you can comment on or make changes to this bug.