Bug 443926 (pyephem-review)

Well...

* pyephem seems to be borrowing libastro codes from XEphem.

  From: http://rhodesmill.org/pyephem/
----------------------------------------------------------------------
You can learn more about and download the wonderful XEphem application
from which PyEphem derives its computation engine;
it has long been written and maintained by Elwood Charles Downey.
-----------------------------------------------------------------------
  I took the diff between xephem-3.7.3/libastro/ in
  http://www.clearskyinstitute.com/xephem/xephem-3.7.3.tar.gz and
  pyephem-3.7.2.3/libastro-3.7.2, and
  actually the diff is very small (i.e. codes are almost same)

* XEphem license is NO for Fedora:
  http://www.clearskyinstitute.com/xephem/download.html

Would you check if license of libastro part is really okay for
Fedora?

I know about XEphem license, but this does not apply on libastro, quote from
COPYING (about libastro):

"You can redistribute and/or modify both works, as distributed in this
package, under the terms of the GNU Lesser General Public License
(LGPL) version 3..."

Same case with libpng, it's shipped as par of Xephem, but xephem is not the
upstream.

mailed upstream to get their opinion.

Created attachment 303682 [details]
mail from upstream

0.) The use of env is kind of useless here.

env CFLAGS="$RPM_OPT_FLAGS" python setup.py build 
env CFLAGS="$RPM_OPT_FLAGS" python setup.py install --root=$RPM_BUILD_ROOT

1.) Requires:	python

This is useless as well. The dependency on python has to be versioned, as the
file names are versioned, and I believe the correct one is automatically
generated anyways.

2.) rpmlint outputs these:

pyephem.x86_64: E: non-executable-script
/usr/lib64/python2.5/site-packages/ephem/tests/test_usno.py 0644
pyephem.x86_64: E: non-executable-script
/usr/lib64/python2.5/site-packages/ephem/tests/test_dates.py 0644
pyephem.x86_64: E: non-executable-script
/usr/lib64/python2.5/site-packages/ephem/tests/test_usno_equinoxes.py 0644
pyephem.x86_64: E: non-executable-script
/usr/lib64/python2.5/site-packages/ephem/tests/ephem_test.py 0644
pyephem.x86_64: E: non-executable-script
/usr/lib64/python2.5/site-packages/ephem/tests/test_bodies.py 0644
pyephem.x86_64: E: non-executable-script
/usr/lib64/python2.5/site-packages/ephem/tests/test_rst.py 0644
pyephem.x86_64: E: non-executable-script
/usr/lib64/python2.5/site-packages/ephem/tests/test_angles.py 0644
pyephem.x86_64: E: non-executable-script
/usr/lib64/python2.5/site-packages/ephem/tests/test_constants.py 0644

Do you believe those should realy be installed? What making them executable and
utilizing the %test section then?

Lubomir, thank you, you're right. All issues resolved in current version of spec
file.

Now this was fast. Not seeing anything that would violate the guidelines --

APPROVED

And thank you for the package.

New Package CVS Request
=======================
Package Name: pyephem 
Short Description: The astronomy library for Python
Owners: mmahut
Branches: F-8, F-9 (does this exist yet?), EL-5
Cvsextras Commits: yes

cvs done. 

(yes, F-9 is available now). 

Thank you!

pyephem is in EPEL 6 and current releases of Fedora, but is not yet in EPEL 7. Please consider this a package change request for the inclusion of pyephem in EPEL 7.