Bug 444113

Summary:	Review Request: gnome-valgrind-session - Run an entire GNOME session under valgrind
Product:	[Fedora] Fedora	Reporter:	Debarshi Ray <debarshir>
Component:	Package Review	Assignee:	Rakesh Pandit <rpandit>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	dmalcolm, fedora-package-review, notting, rpandit
Target Milestone:	---	Flags:	rpandit: fedora-review+ j: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-09-12 04:40:21 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Debarshi Ray 2008-04-25 03:22:44 UTC

Spec URL: http://rishi.fedorapeople.org/gnome-valgrind-session.spec
SRPM URL: http://rishi.fedorapeople.org/gnome-valgrind-session-1.1-1.fc8.src.rpm


Description:

GNOME Valgrind Session adds new types of GNOME session to the login manager's
session menu. These let you instrument your entire session with Valgrind for
debugging purposes. The generated logs are collected and subjected to simple
postprocessing when you log out. The result is saved to a file in your home
directory.

Comment 1 Debarshi Ray 2008-04-25 03:24:07 UTC

*** Bug 216517 has been marked as a duplicate of this bug. ***

Comment 2 Rakesh Pandit 2008-08-12 05:16:23 UTC

Expect a review in few days.

Comment 3 Rakesh Pandit 2008-08-23 20:58:43 UTC

APPROVED

Looks sane to me.

rpmlint output: clean

Build successfully:
http://koji.fedoraproject.org/koji/taskinfo?taskID=781728

Required:
[x] Name 
[x] License -- Public Domain
[x] Spec file is in American Eng and legible
[x] Build successfully
[x] BuildRequires 
[x] Duplicate files - nil
[NA] locale
[x] permissions -- okay
[x]  source link correct
[x] packaging guidlines
[x] Buildroot correct
[x] owns every directory it creates
[x] file encoding - checked
[x] package has no dependency on files in %doc
[x] gui
[x] No dependencies outside FHS guidelines
[x] md5sum
Source from site: 4988af57dc895509ce01e2742883f47b
Source from srpm: 4988af57dc895509ce01e2742883f47b
[x] package owns all directories it created -- 1
[x] description & summary -- okay
[x] %install & %clean section have rm -rf $RPM_BUILD_ROOT

Optional suggestions:
a. optional: check .desktop file 
[rpmbuild@rocky gnome-valgrind-session-1.1]$ desktop-file-validate gnome-valgrind-errors.desktop
gnome-valgrind-errors.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated
gnome-valgrind-errors.desktop: error: value "XSession" for key "Type" in group "Desktop Entry" is not a registered type value ("Application", "Link" and "Directory")

[rpmbuild@rocky gnome-valgrind-session-1.1]$ desktop-file-validate gnome-valgrind-leaks.desktop 
gnome-valgrind-leaks.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated
gnome-valgrind-leaks.desktop: error: value "XSession" for key "Type" in group "Desktop Entry" is not a registered type value ("Application", "Link" and "Directory")

*You can ignore them*

Key NA = N/A, x = Check, ! = Problem, ? = Not evaluated

Comment 4 Rakesh Pandit 2008-09-06 08:30:01 UTC

ping?
you may like to request for cvs and import.
Thanks,

Comment 5 Debarshi Ray 2008-09-06 09:37:21 UTC

New Package CVS Request
=======================
Package Name: gnome-valgrind-session
Short Description: Run an entire GNOME session under valgrind
Owners: rishi
Branches: F-8 F-9
InitialCC:

Comment 6 Rakesh Pandit 2008-09-10 06:53:23 UTC

corrected the flags.

Comment 7 Jason Tibbitts 2008-09-11 00:05:55 UTC

CVS done.

Comment 8 Debarshi Ray 2008-09-12 04:39:39 UTC

(In reply to comment #3)
> Optional suggestions:
> a. optional: check .desktop file 

Fixed it in CVS.

Comment 9 Debarshi Ray 2008-09-12 04:40:21 UTC

Tagged and built in Rawhide.