Spec URL: http://rishi.fedorapeople.org/gnome-valgrind-session.spec SRPM URL: http://rishi.fedorapeople.org/gnome-valgrind-session-1.1-1.fc8.src.rpm Description: GNOME Valgrind Session adds new types of GNOME session to the login manager's session menu. These let you instrument your entire session with Valgrind for debugging purposes. The generated logs are collected and subjected to simple postprocessing when you log out. The result is saved to a file in your home directory.
*** Bug 216517 has been marked as a duplicate of this bug. ***
Expect a review in few days.
APPROVED Looks sane to me. rpmlint output: clean Build successfully: http://koji.fedoraproject.org/koji/taskinfo?taskID=781728 Required: [x] Name [x] License -- Public Domain [x] Spec file is in American Eng and legible [x] Build successfully [x] BuildRequires [x] Duplicate files - nil [NA] locale [x] permissions -- okay [x] source link correct [x] packaging guidlines [x] Buildroot correct [x] owns every directory it creates [x] file encoding - checked [x] package has no dependency on files in %doc [x] gui [x] No dependencies outside FHS guidelines [x] md5sum Source from site: 4988af57dc895509ce01e2742883f47b Source from srpm: 4988af57dc895509ce01e2742883f47b [x] package owns all directories it created -- 1 [x] description & summary -- okay [x] %install & %clean section have rm -rf $RPM_BUILD_ROOT Optional suggestions: a. optional: check .desktop file [rpmbuild@rocky gnome-valgrind-session-1.1]$ desktop-file-validate gnome-valgrind-errors.desktop gnome-valgrind-errors.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated gnome-valgrind-errors.desktop: error: value "XSession" for key "Type" in group "Desktop Entry" is not a registered type value ("Application", "Link" and "Directory") [rpmbuild@rocky gnome-valgrind-session-1.1]$ desktop-file-validate gnome-valgrind-leaks.desktop gnome-valgrind-leaks.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated gnome-valgrind-leaks.desktop: error: value "XSession" for key "Type" in group "Desktop Entry" is not a registered type value ("Application", "Link" and "Directory") *You can ignore them* Key NA = N/A, x = Check, ! = Problem, ? = Not evaluated
ping? you may like to request for cvs and import. Thanks,
New Package CVS Request ======================= Package Name: gnome-valgrind-session Short Description: Run an entire GNOME session under valgrind Owners: rishi Branches: F-8 F-9 InitialCC:
corrected the flags.
CVS done.
(In reply to comment #3) > Optional suggestions: > a. optional: check .desktop file Fixed it in CVS.
Tagged and built in Rawhide.