Bug 444165
| Summary: | Review Request: mkrdns - automatic reverse DNS zone generator | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jonathan Steffan <jonathansteffan> |
| Component: | Package Review | Assignee: | Till Maas <opensource> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bdpepple, fedora-package-review, notting, opensource |
| Target Milestone: | --- | Flags: | opensource:
fedora-review-
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-12-16 01:29:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
Jonathan Steffan
2008-04-25 15:49:06 UTC
NEEDSWORK: rpmlint mkrdns.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 11) - after Buildarch: and Requires: you inserted tabs but after all other tags you only used spaces, therefore you should change this. You should remove the "Requires" anyhow, because they are already added automatically by rpm for perl requirements. Naming: ok License: ok (GPLv2+), not included Building: ok, builds in koji Clean section: ok Macro Usage: ok Source Package: ok, matches upstream, latest version: 474ffb39d1eb615d0e9d8a7d52a27953 mkrdns-3_3.gz 474ffb39d1eb615d0e9d8a7d52a27953 mkrdns-3.3-1.fc8/mkrdns-3_3.gz Buildroot: ok %files: ok Besides the mixed whitespace, there is another minor issue: You write /usr/bin/pod2man instead of just pod2man, which does not make sense to me, because on my machine install is also in /usr/bin and you rely on /usr/bin being in the path there. Also the timestamp of the executable is lost, maybe you can change the spec to preserve it, but I do not know a good way to do this. In conclusion: Remove the tab after Buildarch, remove the Requires: and remove the /usr/bin from the pod2man invocation, then I will approve this package. WRT the timestamp": try
zcat %{SOURCE0} > $RPM_BUILD_ROOT%{_bindir}/mkrdns
chmod 0755 $RPM_BUILD_ROOT%{_bindir}/mkrdns
touch -r ${SOURCE0} $RPM_BUILD_ROOT%{_bindir}/mkrdns
ping? Are you still wishing to submit this package to Fedora? There's been no reply to Till's review 3 months ago. I'll put some more work into this shortly. I sent a patch upstream and never got a response back. I'll try again with upstream, and if that fails, should I carry the patch in the package? You can ship the package with your own patch, if you do not reach upstream. But please keep trying, maybe upstream is on vacation or lost your previous mails. Is there some estimate when this review can be finished? If you want to finish the package, please reopen. |