Bug 444165 - Review Request: mkrdns - automatic reverse DNS zone generator
Review Request: mkrdns - automatic reverse DNS zone generator
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Till Maas
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2008-04-25 11:49 EDT by Jonathan Steffan
Modified: 2008-12-15 20:29 EST (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2008-12-15 20:29:21 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
opensource: fedora‑review-

Attachments (Terms of Use)

  None (edit)
Description Jonathan Steffan 2008-04-25 11:49:06 EDT
Spec URL: http://jsteffan.fedorapeople.org/SRPMS/mkrdns.spec
SRPM URL: http://jsteffan.fedorapeople.org/SRPMS/mkrdns-3.3-1.fc8.src.rpm
Description: An automatic reverse DNS zone generator
Comment 1 Till Maas 2008-05-03 15:44:01 EDT
NEEDSWORK: rpmlint
mkrdns.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 11)
- after Buildarch: and Requires: you inserted tabs but after all other tags you
only used spaces, therefore you should change this. You should remove the
"Requires" anyhow, because they are already added automatically by rpm for perl

Naming: ok
License: ok (GPLv2+), not included
Building: ok, builds in koji
Clean section: ok
Macro Usage: ok
Source Package: ok, matches upstream, latest version:
474ffb39d1eb615d0e9d8a7d52a27953  mkrdns-3_3.gz
474ffb39d1eb615d0e9d8a7d52a27953  mkrdns-3.3-1.fc8/mkrdns-3_3.gz

Buildroot: ok
%files: ok

Besides the mixed whitespace, there is another minor issue:
You write /usr/bin/pod2man instead of just pod2man, which does not make sense to
me, because on my machine install is also in /usr/bin and you rely on /usr/bin
being in the path there.

Also the timestamp of the executable is lost, maybe you can change the spec to
preserve it, but I do not know a good way to do this.

In conclusion: Remove the tab after Buildarch, remove the Requires: and remove
the /usr/bin from the pod2man invocation, then I will approve this package.
Comment 2 manuel wolfshant 2008-05-03 22:04:05 EDT
WRT the timestamp": try
  zcat %{SOURCE0} > $RPM_BUILD_ROOT%{_bindir}/mkrdns
  chmod 0755 $RPM_BUILD_ROOT%{_bindir}/mkrdns
  touch -r ${SOURCE0}  $RPM_BUILD_ROOT%{_bindir}/mkrdns
Comment 3 Till Maas 2008-05-14 17:17:37 EDT
Comment 4 Brian Pepple 2008-08-10 20:19:46 EDT
Are you still wishing to submit this package to Fedora?  There's been no reply to Till's review 3 months ago.
Comment 5 Jonathan Steffan 2008-08-11 15:10:58 EDT
I'll put some more work into this shortly. I sent a patch upstream and never got a response back. I'll try again with upstream, and if that fails, should I carry the patch in the package?
Comment 6 Till Maas 2008-08-13 04:09:49 EDT
You can ship the package with your own patch, if you do not reach upstream. But please keep trying, maybe upstream is on vacation or lost your previous mails.
Comment 7 Till Maas 2008-11-07 06:45:44 EST
Is there some estimate when this review can be finished?
Comment 8 Till Maas 2008-12-15 20:29:21 EST
If you want to finish the package, please reopen.

Note You need to log in before you can comment on or make changes to this bug.