Bug 444625

Some review checks:

+ rpmlint of source package ok.
+ Local buid works fine.
+ Copyright ok

- I think the whole documentatioon should put into %{_docdir]/GMT
- What is the task of the all subpackage which doesn't contain any files.

(In reply to comment #1)
> - I think the whole documentation should put into %{_docdir]/GMT

Possibly.  The GMT install script would make the following subdirs:

pdf
man
web
tut

I could see tutorial going in doc/tutorial.  As for html, can web servers serve
content out of /usr/share?

> - What is the task of the all subpackage which doesn't contain any files.

%package        all
Summary:        All documentation for GMT
Group:          Applications/Engineering
Requires:       %{name} = %{version}-%{release}
Requires:       %{name}-pdf = %{version}-%{release}
Requires:       %{name}-html = %{version}-%{release}
Requires:       %{name}-tutorial = %{version}-%{release}

to bring in all doc packages in one shot.

I think that it would be better to call the package GMT-doc for
consistency with most of the other packages. Also the Group should
be
Group:  Documentation

I think that all the docs should be in only one package.

The html docs should not be installed to be served by a web server but 
for local browsing.

Also I think that it would be better if the docs were installed in
%{_docdir}/GMT-%{version}/

One think which is not completely clear to me is whether this 
package should depend on GMT or not. This is not so clear to me.
Are the examples used in the tutorial or the doc? If so it could depend
on GMT-examples.

How about this one:

Spec URL: http://www.cora.nwra.com/~orion/fedora/GMT-docs
SRPM URL: http://www.cora.nwra.com/~orion/fedora/GMT-docs-4.3.0-1.src.rpm

* Tue Apr 6 2008 Orion Poplawski <orion.com> 4.3.0-1
- Update to 4.3.0
- Make single package

Technically, GMT owns %{_docdir}/GMT-%{version}/, so it should require GMT,
though perhaps not a big deal.

I suggest calling the package GMT-doc and not GMT-docs to be
more consistent with the guidelines and most of the packages.

Also the requires for GMT should be
Requires:       GMT = %{version}
since the release are not correlated.

Otherwise looks good.

* Mon Apr 12 2008 Orion Poplawski <orion.com> 4.3.0-2
- Rename to GMT-doc
- Require only GMT-%%{version}, drop release

Spec URL: http://www.cora.nwra.com/~orion/fedora/GMT-doc.spec
SRPM URL: http://www.cora.nwra.com/~orion/fedora/GMT-doc-4.3.0-2.src.rpm

Thanks!

* rpmlint not problematic
GMT-doc.noarch: E: zero-length /usr/share/doc/GMT-4.3.0/html/GMT_Docs/img246.png
* free software, license included
* follow guidelines
* match upstream
e068d5be0859c1ea5a8a0b15d4ad5810  GMT4.3.0_pdf.tar.bz2
633f4e648c80d920c4c2080b58fc1fe8  GMT4.3.0_tut.tar.bz2
3fcef23a62b61d4d6abcb8b5b1a4a701  GMT4.3.0_web.tar.bz2
* %files section right

APPROVED

New Package CVS Request
=======================
Package Name: GMT-doc
Short Description: Documentation for Generic Mapping Tools
Owners: orion
Branches: F-9 F-8 F-7 EL-5 EL-4
InitialCC: 
Cvsextras Commits: yes

cvs done.

Checked in and built.