Bug 444763

Summary:	Review Request: vaspview - VASP Data Viewer
Product:	[Fedora] Fedora	Reporter:	Dominik 'Rathann' Mierzejewski <dominik>
Component:	Package Review	Assignee:	Nicolas Chauvet (kwizart) <kwizart>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting
Target Milestone:	---	Flags:	kwizart: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	1.05-2.fc8	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-06-14 04:18:21 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dominik 'Rathann' Mierzejewski 2008-04-30 14:37:55 UTC

Spec URL: http://rathann.fedorapeople.org/review/vaspview.spec
SRPM URL: http://rathann.fedorapeople.org/review/vaspview-1.05-1.src.rpm
Description: 

This is a scientific visualization package for examining output files
generated by the Vienna Ab-initio Simulation Package, a package for
performing ab-initio quantum-mechanical molecular dynamics using
pseudopotentials and a plane wave basis set. The project was initiated
when a chemical engineering professor requested assitance in visualizing
output files produced by the above package. It displays iso-surfaces and
slices of a three-dimensional data set, along with the atoms that make
up the molecule the calculations were performed for, and allows symbolic
bonds to be inserted between them.

Comment 1 Nicolas Chauvet (kwizart) 2008-05-28 11:51:00 UTC

 - starting review -

Few notes: 
* vendor field should remains empty
desktop-file-install --vendor="" \

* Why there is no dist macro for the release tag ?

* last source is 2001/08, this is old. (but it still work without patch, unless
for the missing  "no newline at end of file" which doesn't seems to matter much
for now).
There could be a problem to package software when upstream is dead, as this
package could be improved (it cannot open a dialog window when opening a file).
Visualization remains hard, etc.

* The source tarball used, bundles a pre-built binary for win32. It have to be
removed.

So there may be one suggestion. I wonder if the project could be merged with
GLC_player. That's a 3D model visualization tool for the obj format. Anyway i
think it worst the case to ask... Note that if the package is useful as it is, I
don't see any blocker by itself...

Comment 2 Dominik 'Rathann' Mierzejewski 2008-05-31 16:26:06 UTC

http://rathann.fedorapeople.org/review/vaspview.spec
http://rathann.fedorapeople.org/review/vaspview-1.05-2.src.rpm

Fixed all issues.

Comment 3 Nicolas Chauvet (kwizart) 2008-06-03 11:40:46 UTC

APPROVED

Comment 4 Dominik 'Rathann' Mierzejewski 2008-06-04 17:58:18 UTC

Thanks for the review!

New Package CVS Request
=======================
Package Name: vaspview
Short Description: VASP Data Viewer
Owners: rathann
Branches: F-8 F-9 EL-5
InitialCC: 
Cvsextras Commits: yes

Comment 5 Kevin Fenzi 2008-06-04 21:29:14 UTC

cvs done.

Comment 6 Nicolas Chauvet (kwizart) 2008-06-13 00:36:41 UTC

This package (vaspview) with hasn't been imported into the cvs yet...

Comment 7 Fedora Update System 2008-06-13 09:57:35 UTC

vaspview-1.05-2.fc9 has been submitted as an update for Fedora 9

Comment 8 Fedora Update System 2008-06-13 10:00:25 UTC

vaspview-1.05-2.fc8 has been submitted as an update for Fedora 8

Comment 9 Fedora Update System 2008-06-14 04:16:47 UTC

vaspview-1.05-2.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2008-06-14 04:18:19 UTC

vaspview-1.05-2.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.