Spec URL: http://rathann.fedorapeople.org/review/vaspview.spec SRPM URL: http://rathann.fedorapeople.org/review/vaspview-1.05-1.src.rpm Description: This is a scientific visualization package for examining output files generated by the Vienna Ab-initio Simulation Package, a package for performing ab-initio quantum-mechanical molecular dynamics using pseudopotentials and a plane wave basis set. The project was initiated when a chemical engineering professor requested assitance in visualizing output files produced by the above package. It displays iso-surfaces and slices of a three-dimensional data set, along with the atoms that make up the molecule the calculations were performed for, and allows symbolic bonds to be inserted between them.
- starting review - Few notes: * vendor field should remains empty desktop-file-install --vendor="" \ * Why there is no dist macro for the release tag ? * last source is 2001/08, this is old. (but it still work without patch, unless for the missing "no newline at end of file" which doesn't seems to matter much for now). There could be a problem to package software when upstream is dead, as this package could be improved (it cannot open a dialog window when opening a file). Visualization remains hard, etc. * The source tarball used, bundles a pre-built binary for win32. It have to be removed. So there may be one suggestion. I wonder if the project could be merged with GLC_player. That's a 3D model visualization tool for the obj format. Anyway i think it worst the case to ask... Note that if the package is useful as it is, I don't see any blocker by itself...
http://rathann.fedorapeople.org/review/vaspview.spec http://rathann.fedorapeople.org/review/vaspview-1.05-2.src.rpm Fixed all issues.
APPROVED
Thanks for the review! New Package CVS Request ======================= Package Name: vaspview Short Description: VASP Data Viewer Owners: rathann Branches: F-8 F-9 EL-5 InitialCC: Cvsextras Commits: yes
cvs done.
This package (vaspview) with hasn't been imported into the cvs yet...
vaspview-1.05-2.fc9 has been submitted as an update for Fedora 9
vaspview-1.05-2.fc8 has been submitted as an update for Fedora 8
vaspview-1.05-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
vaspview-1.05-2.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.