Bug 445847

Summary:	Review Request: vegastrike-music - Music for Vega Strike
Product:	[Fedora] Fedora	Reporter:	Hans de Goede <hdegoede>
Component:	Package Review	Assignee:	Gwyn Ciesla <gwync>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting
Target Milestone:	---	Flags:	gwync: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	0.5.0-3	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-05-17 22:27:33 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Hans de Goede 2008-05-09 11:28:44 UTC

Spec URL: http://people.atrpms.net/~hdegoede/vegastrike-music.spec
SRPM URL: http://people.atrpms.net/~hdegoede/vegastrike-music-0.5.0-1.src.rpm
Description:
Music for Vega Strike, a GPL 3D OpenGL Action RPG space sim that allows
a player to trade and bounty hunt. This archive contains the music files
necessary to hear music in VegaStrike. These files are *not* essential to
play the game.

Comment 1 Gwyn Ciesla 2008-05-15 15:31:18 UTC

Downloading. . . . :)

Comment 2 Gwyn Ciesla 2008-05-15 16:00:25 UTC

GPL+ is not valid, needs a version, a la GPLv1+, GPLv2+, etc.

Fix perms, some .oggs are marked executable.  

Otherwise, passes all MUSTS.

Comment 3 Mamoru TASAKA 2008-05-15 16:56:44 UTC

(In reply to comment #2)
> GPL+ is not valid, 

It is valid:
http://fedoraproject.org/wiki/Licensing

Comment 4 Gwyn Ciesla 2008-05-15 17:01:42 UTC

So it is.  My bad.  Should have relied on rpmlint not complaining, which it does
loudly if you use an invalid tag.  Just the perms, then.

Comment 5 Hans de Goede 2008-05-15 19:18:17 UTC

(In reply to comment #2)
> Fix perms, some .oggs are marked executable.  

Only in the tarbal (as they are upstream), not in the build rpm, as they get
installed with -m 644:

install -p -m 644 *.ogg $RPM_BUILD_ROOT%{_datadir}/vegastrike/music

Comment 6 Hans de Goede 2008-05-15 19:22:27 UTC

Argh, stop the presses, upstream just announced that the they've gotten
permission from the author who's mujsic I've removed to distribute it under the GPL.

So now I'm of todo a new music package ...

Comment 7 Gwyn Ciesla 2008-05-15 19:28:00 UTC

Re #5.  Doh!  Eye fart.  More caffeine. . . 

Re #6.  That's hysterical. :) I'll take a look once you get it posted.  'Spect
it'll be fine, though.

Comment 8 Hans de Goede 2008-05-16 12:59:25 UTC

Ok,

New version ready for review:
Spec URL: http://people.atrpms.net/~hdegoede/vegastrike-music.spec
SRPM URL: http://people.atrpms.net/~hdegoede/vegastrike-music-0.5.0-1.src.rpm

Basicly the tarbal was respun to include the earlier omitted numbers, no other
changes.

Comment 9 Gwyn Ciesla 2008-05-16 13:17:01 UTC

Downloading.  It's a fair bit bigger. :)

Comment 10 Gwyn Ciesla 2008-05-16 13:43:09 UTC

Looks great.  APPROVED.

Comment 11 Hans de Goede 2008-05-16 14:35:49 UTC

Thanks!

New Package CVS Request
=======================
Package Name:      vegastrike-music
Short Description: Music for Vega Strike
Owners:            jwrdegoede
Branches:          F-9
InitialCC:
Cvsextras Commits: Yes

Comment 12 Kevin Fenzi 2008-05-16 15:38:06 UTC

cvs done.

Comment 13 Gwyn Ciesla 2008-05-16 15:46:00 UTC

Beautiful. Thanks!

Comment 14 Gwyn Ciesla 2008-05-16 15:46:27 UTC

Oops, commented on wrong bug.  Ignore.

Comment 15 Fedora Update System 2008-05-17 09:38:49 UTC

vegastrike-data-0.5.0-3,vegastrike-music-0.5.0-2 has been submitted as an update for Fedora 9

Comment 16 Hans de Goede 2008-05-17 09:49:55 UTC

Imported, build and on its way to F-9 updates.

Comment 17 Fedora Update System 2008-05-17 22:27:31 UTC

vegastrike-data-0.5.0-3, vegastrike-music-0.5.0-2 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 18 Fedora Update System 2008-07-26 05:55:21 UTC

vegastrike-data-0.5.0-3, vegastrike-music-0.5.0-2 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.