Spec URL: http://people.atrpms.net/~hdegoede/vegastrike-music.spec SRPM URL: http://people.atrpms.net/~hdegoede/vegastrike-music-0.5.0-1.src.rpm Description: Music for Vega Strike, a GPL 3D OpenGL Action RPG space sim that allows a player to trade and bounty hunt. This archive contains the music files necessary to hear music in VegaStrike. These files are *not* essential to play the game.
Downloading. . . . :)
GPL+ is not valid, needs a version, a la GPLv1+, GPLv2+, etc. Fix perms, some .oggs are marked executable. Otherwise, passes all MUSTS.
(In reply to comment #2) > GPL+ is not valid, It is valid: http://fedoraproject.org/wiki/Licensing
So it is. My bad. Should have relied on rpmlint not complaining, which it does loudly if you use an invalid tag. Just the perms, then.
(In reply to comment #2) > Fix perms, some .oggs are marked executable. Only in the tarbal (as they are upstream), not in the build rpm, as they get installed with -m 644: install -p -m 644 *.ogg $RPM_BUILD_ROOT%{_datadir}/vegastrike/music
Argh, stop the presses, upstream just announced that the they've gotten permission from the author who's mujsic I've removed to distribute it under the GPL. So now I'm of todo a new music package ...
Re #5. Doh! Eye fart. More caffeine. . . Re #6. That's hysterical. :) I'll take a look once you get it posted. 'Spect it'll be fine, though.
Ok, New version ready for review: Spec URL: http://people.atrpms.net/~hdegoede/vegastrike-music.spec SRPM URL: http://people.atrpms.net/~hdegoede/vegastrike-music-0.5.0-1.src.rpm Basicly the tarbal was respun to include the earlier omitted numbers, no other changes.
Downloading. It's a fair bit bigger. :)
Looks great. APPROVED.
Thanks! New Package CVS Request ======================= Package Name: vegastrike-music Short Description: Music for Vega Strike Owners: jwrdegoede Branches: F-9 InitialCC: Cvsextras Commits: Yes
cvs done.
Beautiful. Thanks!
Oops, commented on wrong bug. Ignore.
vegastrike-data-0.5.0-3,vegastrike-music-0.5.0-2 has been submitted as an update for Fedora 9
Imported, build and on its way to F-9 updates.
vegastrike-data-0.5.0-3, vegastrike-music-0.5.0-2 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.