Bug 447219
| Summary: | Review Request: ucview - Image and video capture application using unicap toolkit | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Robert Scheck <redhat-bugzilla> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-05-19 19:33:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Robert Scheck
2008-05-18 21:42:20 UTC
rpmlint on rpm gave => ucview.i386: W: non-conffile-in-etc /etc/gconf/schemas/ucview.schemas A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file. can you mark this file as %config in spec? If this is *really* correct, I can do so. I spent a lot of time searching how to package GUI software correct and saw, that nearly every maintainer does this different. Looking e.g. to http://cvs.fedoraproject.org/viewcvs/*checkout*/ devel/gconf-editor/gconf-editor.spec, I can't see %config there. So really a %config, yes? Or maybe even %config(noreplace)? If I recall well the files in /etc/gconf/schemas/ are not real config files, they should be in %_datadir, but for an unknwon reason they are in /etc instead. Thanks Patrice. Review: + package builds in mock (development i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=616787 + rpmlint is silent for SRPM But NOT for RPM. ucview.i386: W: non-conffile-in-etc /etc/gconf/schemas/ucview.schemas == Ok to ignore. + source files match upstream. e241951a418db9bd66d8da612af15328 ucview-0.17.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are used correctly. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + scrollkeeper,Gconf2,gtk-update-icon-cache scriptlets are used. + Desktop file installed correctly. + GUI app. APPROVED. Parag, thank you very much for the fast review. New Package CVS Request ======================= Package Name: ucview Short Description: Image and video capture application using unicap toolkit Owners: robert Branches: F-7 F-8 F-9 EL-4 EL-5 InitialCC: Cvsextras Commits: no cvs done. 39027 (unicap): Build on target fedora-5-epel succeeded. Package: unicap-0.2.23-1.fc7 Tag: dist-fc7-updates-candidate Status: complete Package: unicap-0.2.23-1.fc8 Tag: dist-f8-updates-candidate Status: complete Package: unicap-0.2.23-1.fc9 Tag: dist-f9-updates-candidate Status: complete Package: unicap-0.2.23-1.fc10 Tag: dist-f10 Status: complete Gna. Wrong copy and paste. 39031 (ucview): Build on target fedora-5-epel succeeded. Package: ucview-0.17-1.fc7 Tag: dist-fc7-updates-candidate Status: complete Package: ucview-0.17-1.fc8 Tag: dist-f8-updates-candidate Status: complete Package: ucview-0.17-1.fc9 Tag: dist-f9-updates-candidate Status: complete Package: ucview-0.17-1.fc10 Tag: dist-f10 Status: complete |