Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: http://labs.linuxnetz.de/bugzilla/ucview.spec SRPM URL: http://labs.linuxnetz.de/bugzilla/ucview-0.17-1.src.rpm UCView is a video image capture application using the unicap toolkit. It provides a simple way to parametrise the video device, can capture still images from the video stream or record the stream as mpeg file. By using unicap, it can access many different video capture devices like webcams, video grabber boards, IEEE-1394 (FireWire) cameras and others. It would be great, if this review can happen just before LinuxTag 2008, as this package is in use on the Asus EeePC we're going to present there with a pure Fedora 9 installation on it... ;-)
rpmlint on rpm gave => ucview.i386: W: non-conffile-in-etc /etc/gconf/schemas/ucview.schemas A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file. can you mark this file as %config in spec?
If this is *really* correct, I can do so. I spent a lot of time searching how to package GUI software correct and saw, that nearly every maintainer does this different. Looking e.g. to http://cvs.fedoraproject.org/viewcvs/*checkout*/ devel/gconf-editor/gconf-editor.spec, I can't see %config there. So really a %config, yes? Or maybe even %config(noreplace)?
If I recall well the files in /etc/gconf/schemas/ are not real config files, they should be in %_datadir, but for an unknwon reason they are in /etc instead.
Thanks Patrice. Review: + package builds in mock (development i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=616787 + rpmlint is silent for SRPM But NOT for RPM. ucview.i386: W: non-conffile-in-etc /etc/gconf/schemas/ucview.schemas == Ok to ignore. + source files match upstream. e241951a418db9bd66d8da612af15328 ucview-0.17.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are used correctly. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + scrollkeeper,Gconf2,gtk-update-icon-cache scriptlets are used. + Desktop file installed correctly. + GUI app. APPROVED.
Parag, thank you very much for the fast review. New Package CVS Request ======================= Package Name: ucview Short Description: Image and video capture application using unicap toolkit Owners: robert Branches: F-7 F-8 F-9 EL-4 EL-5 InitialCC: Cvsextras Commits: no
cvs done.
39027 (unicap): Build on target fedora-5-epel succeeded. Package: unicap-0.2.23-1.fc7 Tag: dist-fc7-updates-candidate Status: complete Package: unicap-0.2.23-1.fc8 Tag: dist-f8-updates-candidate Status: complete Package: unicap-0.2.23-1.fc9 Tag: dist-f9-updates-candidate Status: complete Package: unicap-0.2.23-1.fc10 Tag: dist-f10 Status: complete
Gna. Wrong copy and paste.
39031 (ucview): Build on target fedora-5-epel succeeded. Package: ucview-0.17-1.fc7 Tag: dist-fc7-updates-candidate Status: complete Package: ucview-0.17-1.fc8 Tag: dist-f8-updates-candidate Status: complete Package: ucview-0.17-1.fc9 Tag: dist-f9-updates-candidate Status: complete Package: ucview-0.17-1.fc10 Tag: dist-f10 Status: complete