Bug 447366
| Summary: | Review Request: python-virtkey | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | jmccann |
| Component: | Package Review | Assignee: | Matthias Clasen <mclasen> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | cschalle, fedora-package-review, mclasen, notting, panemade |
| Target Milestone: | --- | Flags: | mclasen:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-05-22 03:39:25 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
jmccann
2008-05-19 17:40:10 UTC
Had to add a BuildRequires for libXtst-devel to make it build in mock Warnings from rpmlint: rpmlint /var/lib/mock/fedora-9-i386/result/python-virtkey-0.50-1.fc9.i386.rpm python-virtkey.i386: W: no-documentation python-virtkey.i386: E: non-standard-executable-perm /usr/lib/python2.5/site-packages/virtkey.so 0775 Nothing to do about the nonexisting docs, but the permissions should be fixed to 0755 package name: ok spec file name: ok packaging guidelines: ok, but - the explicit requires on gtk2 is unnecessary, and should be dropped license: ok license field: ok license file: ok spec file language: ok spec file legibility: ok upstream source: ok buildable: yes ExcludeArch: n/a BuildRequires; need to add libXtst-devel locale handling: ok ldconfig: n/a relocatable: n/a directory ownership: ok duplicate files: ok file permissions: see above %clean: ok macro use: ok permissible content: ok large docs: n/a %doc content: ok headers: n/a static libs: n/a pkgconfig files: n/a shared libs: n/a -devel package: n/a libtool archives: ok gui app: ok %install: ok utf8 filenames: ok Package already submitted to fedora check https://bugzilla.redhat.com/show_bug.cgi?id=445454 Ok, update files in place. Thanks. Re: comment 2, the packages are virtually identical, so I'm going to approve this one anyway. I'm sure Jon will be happy to make sindrepb comaintainer or even the main maintainer of this package... Approved. mclasen, I think we use first come first serve policy. So I have seen that first package always gets priority and second one will get closed as duplicate. I even can't see any comment from you to Sindre's Package review ticket. This package is failed in koji build. look http://koji.fedoraproject.org/koji/taskinfo?taskID=622125 Suits me well for reviewing python packages, I guess...
Looking at setup.py, this is obviously not going to fly:
from distutils.core import setup, Extension
setup(name="virtkey",
ext_modules=[Extension("virtkey",
["python-virtkey.c","ucs2keysym.c"],include_dirs=['/usr/include/gtk-2.0',
'/usr/include/glib-2.0', '/usr/lib/glib-2.0/include', '/usr/include/pango-1.0',
'/usr/lib/gtk-2.0/include', '/usr/include/cairo'],
libraries=["X11","Xtst","glib-2.0","gdk-x11-2.0"]
)],
version="0.01"
)
I lack the python build foo to say how this would be done correctly.
It just happens to work in mock on i386...
|