Red Hat Bugzilla – Bug 447366
Review Request: python-virtkey
Last modified: 2015-01-14 18:21:14 EST
This is a dependency for the onboard virtual keyboard.
Had to add a BuildRequires for libXtst-devel to make it build in mock
Warnings from rpmlint:
python-virtkey.i386: W: no-documentation
python-virtkey.i386: E: non-standard-executable-perm
Nothing to do about the nonexisting docs, but the permissions should be fixed to
package name: ok
spec file name: ok
packaging guidelines: ok, but
- the explicit requires on gtk2 is unnecessary, and should be dropped
license field: ok
license file: ok
spec file language: ok
spec file legibility: ok
upstream source: ok
BuildRequires; need to add libXtst-devel
locale handling: ok
directory ownership: ok
duplicate files: ok
file permissions: see above
macro use: ok
permissible content: ok
large docs: n/a
%doc content: ok
static libs: n/a
pkgconfig files: n/a
shared libs: n/a
-devel package: n/a
libtool archives: ok
gui app: ok
utf8 filenames: ok
Package already submitted to fedora check
Ok, update files in place. Thanks.
Re: comment 2, the packages are virtually identical, so I'm going to approve
this one anyway. I'm sure Jon will be happy to make email@example.com
comaintainer or even the main maintainer of this package...
I think we use first come first serve policy. So I have seen that first package
always gets priority and second one will get closed as duplicate.
I even can't see any comment from you to Sindre's Package review ticket.
This package is failed in koji build.
Suits me well for reviewing python packages, I guess...
Looking at setup.py, this is obviously not going to fly:
from distutils.core import setup, Extension
'/usr/include/glib-2.0', '/usr/lib/glib-2.0/include', '/usr/include/pango-1.0',
I lack the python build foo to say how this would be done correctly.
It just happens to work in mock on i386...
Ok, giving you the right of way here.
*** This bug has been marked as a duplicate of 445454 ***