Bug 447607

Summary: Review Request: abgraph - ABGraph is a simple tool to benchmark webservers
Product: [Fedora] Fedora Reporter: Marek Mahut <mmahut>
Component: Package ReviewAssignee: Lubomir Rintel <lkundrak>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting
Target Milestone: ---Flags: lkundrak: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-07-02 17:59:35 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
build log from mock none

Description Marek Mahut 2008-05-20 19:35:57 UTC 
Spec URL: http://mmahut.fedorapeople.org/reviews/abgraph/abgraph.spec
SRPM URL: http://mmahut.fedorapeople.org/reviews/abgraph/abgraph-1.0-1.fc8.src.rpm
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=620845
Description: ABGraph is a simple tool to benchmark webservers.
The program uses ab (apache benchmark) to actually
benchmark the selected remote host. A graph in PNG format
is generated with gnuplot and saved to the selected path/file.
Comment 1 Lubomir Rintel 2008-05-20 20:01:10 UTC 
I'll approve this, once you re-roll the package without the %setup weirdness,
and patch out the insecure temporary file uses, as we talked about on irc.

rpmlint is quiet, qa tool is happy, and so am I.
Comment 2 Lubomir Rintel 2008-05-29 01:57:37 UTC 
I am wondering what's the state of this?
Comment 3 Marek Mahut 2008-05-29 14:46:12 UTC 
Lubomir, it's fixed:

  http://mmahut.fedorapeople.org/reviews/abgraph/abgraph-1.1-1.fc8.src.rpm
Comment 4 Lubomir Rintel 2008-05-29 15:10:31 UTC 
Marek: The insecure tmp fix seems well, though I am not sure whether you should
have bumped the version number. Did you agree with upstream on that? If yes, why
don't you include new upstream tarball, or use the alpha tag in revision in case
the release is pending.
Comment 5 Jason Tibbitts 2008-06-18 20:35:38 UTC 
Please remember to set the flags properly when you begin a review.
Comment 6 Peter Fernandes 2008-06-21 03:53:35 UTC 
Created attachment 309963 [details]
build log from mock

The build log from building abgraph with mock.
Comment 7 Peter Fernandes 2008-06-21 03:54:51 UTC 
Comment on attachment 309963 [details]
build log from mock

No errors building abgraph with mock:
mock -r fedora-8-i386 rebuild abgraph-1.0-1.fc8.src.rpm
Comment 8 Marek Mahut 2008-06-21 15:38:40 UTC 
Lubomir, yes, upstream promised to release it this weekend.
Comment 9 Marek Mahut 2008-06-25 20:54:52 UTC 
Lubomir, see new SRPM:
http://mmahut.fedorapeople.org/reviews/abgraph/abgraph-1.1-1.fc8.src.rpm
Comment 10 Lubomir Rintel 2008-07-02 11:55:25 UTC 
Thanks, Marek -- I do not see any more issues with this package.

APPROVED
Comment 11 Marek Mahut 2008-07-02 12:02:35 UTC 
Thanks Lubomir...

New Package CVS Request
=======================
Package Name: abgraph
Short Description: ABGraph is a simple tool to benchmark webservers
Owners: mmahut
Branches: F-8 F-9 EL-5
Cvsextras Commits: yes
Comment 12 Kevin Fenzi 2008-07-02 16:39:53 UTC 
cvs done.
Comment 13 Marek Mahut 2008-07-02 17:59:35 UTC 
Built et al. Thanks all.