Spec URL: http://mmahut.fedorapeople.org/reviews/abgraph/abgraph.spec SRPM URL: http://mmahut.fedorapeople.org/reviews/abgraph/abgraph-1.0-1.fc8.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=620845 Description: ABGraph is a simple tool to benchmark webservers. The program uses ab (apache benchmark) to actually benchmark the selected remote host. A graph in PNG format is generated with gnuplot and saved to the selected path/file.
I'll approve this, once you re-roll the package without the %setup weirdness, and patch out the insecure temporary file uses, as we talked about on irc. rpmlint is quiet, qa tool is happy, and so am I.
I am wondering what's the state of this?
Lubomir, it's fixed: http://mmahut.fedorapeople.org/reviews/abgraph/abgraph-1.1-1.fc8.src.rpm
Marek: The insecure tmp fix seems well, though I am not sure whether you should have bumped the version number. Did you agree with upstream on that? If yes, why don't you include new upstream tarball, or use the alpha tag in revision in case the release is pending.
Please remember to set the flags properly when you begin a review.
Created attachment 309963 [details] build log from mock The build log from building abgraph with mock.
Comment on attachment 309963 [details] build log from mock No errors building abgraph with mock: mock -r fedora-8-i386 rebuild abgraph-1.0-1.fc8.src.rpm
Lubomir, yes, upstream promised to release it this weekend.
Lubomir, see new SRPM: http://mmahut.fedorapeople.org/reviews/abgraph/abgraph-1.1-1.fc8.src.rpm
Thanks, Marek -- I do not see any more issues with this package. APPROVED
Thanks Lubomir... New Package CVS Request ======================= Package Name: abgraph Short Description: ABGraph is a simple tool to benchmark webservers Owners: mmahut Branches: F-8 F-9 EL-5 Cvsextras Commits: yes
cvs done.
Built et al. Thanks all.