Bug 447844
| Summary: | Review Request: krazy2 - KDE code checking tool | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ben Boeckel <fedora> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, itamar, kevin, mtasaka, notting |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-09-23 12:39:44 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Ben Boeckel
2008-05-22 03:29:05 UTC
Forgot to mention that this is my first package and that I need sponsored. After thinking about it a bit, should the plugins in the package be a separate RPM (krazy2-plugins perhaps)? The spec and SRPM have been relocated: http://www.hypersonicosft.org/temp/krazy2-1.11-1.fc9.src.rpm http://www.hypersonicsoft.org/temp/krazy2.spec Rebuild failed: http://koji.fedoraproject.org/koji/taskinfo?taskID=750060 I no longer need sponsored. See: https://bugzilla.redhat.com/show_bug.cgi?id=450371 (Re-adding NEEDSPONSOR: see my comment on bug 450371) Of course this fails, the "make PREFIX=/usr install" for the plugins doesn't use RPM_BUILD_ROOT anywhere, so they aren't installed to the right place. Got them more up-to-date here: http://benboeckel.net/krazy2/krazy2.spec http://benboeckel.net/krazy2/krazy2-2.6-1.fc9.src.rpm Here are some of the questions that I have that need attention: 1) There is one file that needs compiling (src/passbyvalue/passbyvalue.cpp) while everything else is noarch (perl scripts) 2) rpmlint errors saying that there are no binaries and it should be noarch, but that plugin is not noarch as it needs compiled. rpmlint doesn't find it and errors saying that it should then be in /usr/share. Any ideas as to how I should handle that? Maybe an arch-dependent subpackage from a noarch base package? False alarm, thought I had fixed a bug before and didn't think it came from there: http://benboeckel.net/krazy2/krazy2.spec http://benboeckel.net/krazy2/krazy2-2.6-2.fc9.src.rpm Fixed it. Had to patch to get it to accept LIBSUFFIX in passbyvalue. Now it actually installs to the right place. Still rebuild fails: needs investigating... http://koji.fedoraproject.org/koji/taskinfo?taskID=831427 By the way, are you trying rpmbuild as root? If so, please try rpmbuild as a normal user. After you setup rpmdev tree by rpmdev-setuptree (in rpmdevtools rpm) as a normal user, you should be able to try rpmbuild as the user. Yes, I run (ran) it as root. Fixed it up. Thanks. http://benboeckel.net/krazy2/krazy2.spec http://benboeckel.net/krazy2/krazy2-2.6-3.fc9.src.rpm For 2.6-3:
* Source0
- Source tarball must be written by full URL
https://fedoraproject.org/wiki/Packaging/SourceURL
* BuildRequires
-------------------------------------------
327 + pushd doc
328 + make DESTDIR=/builddir/build/BUILDROOT/krazy2-2.6-3.fc10.i386/usr/share/man install
329 perldoc krazyrc.pod > krazyrc.5
!!!330 sh: nroff: command not found
331 list=krazyrc.5; for man in $list; do \
332 echo "Installing man page $man"; \
333 mv -f $man /builddir/build/BUILDROOT/krazy2-2.6-3.fc10.i386/usr/share/man/man5/$man; \
334 done
335 Installing man page krazyrc.5
336 + popd
-------------------------------------------
- Perhaps "groff" is needed for BuildRequires.
* man files
- Files under %_mandir are automatically regarded as %doc.
* Directory ownership issue
- The directory %{perl_vendorlib}/Krazy/ is not owned by any packages
* Documents
- Please add the following files to %doc.
-------------------------------------------
COPYING
README
-------------------------------------------
Fixed. Also added the svn revision number as upstream doesn't bump the version when it gets updated. http://benboeckel.net/krazy2/krazy2.spec http://benboeckel.net/krazy2/krazy2-2.6-4.20080918svn862357.fc9.src.rpm Okay.
* One issue
- "Requires: desktop-file-utils" is not needed.
----------------------------------------------------------
This package (krazy2) is APPROVED by mtasaka
----------------------------------------------------------
(In reply to comment #14) > * One issue > - "Requires: desktop-file-utils" is not needed. Actually, it is. Krazy uses desktop-file-validate (it has 0.14 upstream, 0.15 is in Fedora, so I went with that). Should I comment that in the spec file? (In reply to comment #15) > (In reply to comment #14) > > * One issue > > - "Requires: desktop-file-utils" is not needed. > Actually, it is. Krazy uses desktop-file-validate (it has 0.14 upstream, 0.15 > is in Fedora, so I went with that). Should I comment that in the spec file? Ah, okay. Then I recommend to write in a spec file. (Now I am sponsoring the submitter) New Package CVS Request ======================= Package Name: krazy2 Short Description: KDE code checking tool Owners: mathstuf Branches: F-8 F-9 InitialCC: cvs done. For F-8 and F-9, please submit requests on bodhi: https://admin.fedoraproject.org/updates/ to push the built packages to repositories, then you can close this bug. Just did it this morning (was away for the weekend). Closing. |