Bug 448230
| Summary: | Review Request: xfce4-dict - A Dictionary Client for the Xfce desktop environment | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christoph Wickert <christoph.wickert> |
| Component: | Package Review | Assignee: | Kevin Fenzi <kevin> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, kevin, nonamedotc, notting |
| Target Milestone: | --- | Flags: | kevin:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-05-26 09:58:18 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Christoph Wickert
2008-05-24 19:28:08 UTC
I'd be happy to review this. Look for a full review in a bit. OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPLv2+) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: dbe99b8dbf918e401be41613b3012797 xfce4-dict-0.4.0.tar.gz dbe99b8dbf918e401be41613b3012797 xfce4-dict-0.4.0.tar.gz.orig OK - BuildRequires correct OK - Spec handles locales/find_lang OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package is a GUI app and has a .desktop file OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have subpackages require base package with fully versioned depend. OK - Should have dist tag OK - Should package latest version Issues: 1. rpmlint says: xfce4-dict-plugin.i386: W: no-documentation Can be ignored. I see no issues or blockers here. This package is APPROVED. New Package CVS Request ======================= Package Name: xfce4-dict Short Description: A Dictionary Client for the Xfce desktop environment Owners: cwickert Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes cvs done. Don't forget to follow the end of life procedure on the xfce4-dict-plugin package. Builds for F8, F9 and devel done. Thanks for the review! Package Change Request ====================== Package Name: xfce4-dict New Branches: epel7 Owners: cwickert InitialCC: nonamedotc Branch already exists. |