Red Hat Bugzilla – Bug 215169
Review Request: xfce4-dict-plugin - A XFCE panel plugin to query a Dict server
Last modified: 2007-11-30 17:11:48 EST
Spec URL: http://home.arcor.de/christoph.wickert/fedora/extras/review/SPECS/xfce4-dict-plugin.spec
SRPM URL: http://home.arcor.de/christoph.wickert/fedora/extras/review/SRPMS/xfce4-dict-plugin-0.2.0-1.fc7.src.rpm
Description: With this plugin you can query a dictionary server (see RFC 2229) to search for the translation or explanation of a word. You can also choose a dictionary offered by the server to improve your search results.
Here's a review:
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPL)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
OK - BuildRequires correct
OK - Spec handles locales/find_lang
See below - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane:
OK - Should build in mock.
x86_64/i386 - Should build on all supported archs
OK - Should function as described.
OK - Should have dist tag
OK - Should package latest version
1. Should add a:
2. Should the BuildRequire for xfce4-panel-devel 18.104.22.168 be 22.214.171.124,
since everything else is requiring that version?
Thanks for reviewing this so quickly. I was to tired yesterday to reply.
(In reply to comment #1)
> 1. Should add a:
> to files?
Of course. I have no idea how I managed to delete this line...
> 2. Should the BuildRequire for xfce4-panel-devel 126.96.36.199 be 188.8.131.52,
> since everything else is requiring that version?
No, that's intentional, cause this is what ./configure checks for.
> checking for libxfcegui4-1.0 >= 184.108.40.206... 220.127.116.11
> checking for libxfce4util-1.0 >= 18.104.22.168... 22.214.171.124
> checking for libxfce4panel-1.0 >= 126.96.36.199... 188.8.131.52
I usually make the BuildRequires: as low as possible (to make the packages
easier to rebuild) but the Requires: to the version the plugin was compiled for.
* Sun Nov 12 2006 Christoph Wickert <fedora christoph-wickert de> - 0.2.0-2
- Add %%defattr (#215169).
ok. Looks good to me.The blockers look all solved... this package is APPROVED.
Don't forget to close this package NEXTRELEASE once it's been imported and built.
Also, consider doing a review of a waiting package to help spread out the
(In reply to comment #3)
> Also, consider doing a review of a waiting package to help spread out the
> reviewing load.
I have allready assigned bug #190213 and bug #188542 to me. Will see what I can
do after that.
Imported and built for devel, cvs-sync for FE6 is requested. Closing