Bug 448563

Summary:	Review Request: xorg-x11-drv-suncg14 - X driver for suncg14 hardware
Product:	[Fedora] Fedora	Reporter:	Dennis Gilmore <dennis>
Component:	Package Review	Assignee:	Brian Pepple <bdpepple>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting
Target Milestone:	---	Flags:	bdpepple: fedora-review+ dennis: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-06-06 21:45:13 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dennis Gilmore 2008-05-27 17:16:25 UTC

Spec URL: http://ausil.us/packages/xorg-x11-drv-suncg14.spec
SRPM URL: http://ausil.us/packages/xorg-x11-drv-suncg14-1.1.0-2.fc9.src.rpm
Description: 
X driver for suncg14 hardware

Comment 1 Dennis Gilmore 2008-06-03 23:30:07 UTC

scratch build http://sparc.koji.fedoraproject.org/koji/taskinfo?taskID=58923

Comment 2 Brian Pepple 2008-06-05 00:47:19 UTC

MD5Sum:
9e25784e912cb2f0493b87431fd60773  xf86-video-suncg14-1.1.0.tar.bz2

Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* All necessary BuildRequires listed.
* Make succeeds even when %{_smp_mflags} is defined
* Files have appropriate permissions and owners

Bad:
* rpmlint produces the following error:
xorg-x11-drv-suncg14.sparc64: W: invalid-license MIT/X11

Looking at the license matrix, it looks like it should just be MIT.  You can fix
this when you import this into CVS.

Note: I don't have the hardware to verify that this driver works, but from a
packaging standpoint this package looks fine.

+1 APPROVE.

Comment 3 Dennis Gilmore 2008-06-06 04:24:24 UTC

Package Name: xorg-x11-drv-suncg14
Short Description: X driver for suncg14
Owners: ausil spot jima pjones
Branches: F-9
InitialCC:
Cvsextras Commits: yes

Comment 4 Dennis Gilmore 2008-06-06 21:45:13 UTC

imported and built  thanks for the review