Bug 448566

Summary: Review Request: xorg-x11-drv-sunleo - X driver for sunleo hardware
Product: [Fedora] Fedora Reporter: Dennis Gilmore <dennis>
Component: Package ReviewAssignee: Brian Pepple <bdpepple>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting
Target Milestone: ---Flags: bdpepple: fedora-review+
dennis: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-06-06 21:43:17 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Dennis Gilmore 2008-05-27 17:18:40 UTC
Spec URL: http://ausil.us/packages/xorg-x11-drv-sunleo.spec
SRPM URL: http://ausil.us/packages/xorg-x11-drv-sunleo-1.1.0-3.fc9.git20080526.src.rpm
Description: 
X driver for sunleo hardware

Comment 1 Dennis Gilmore 2008-06-03 23:24:03 UTC
scratch build http://sparc.koji.fedoraproject.org/koji/taskinfo?taskID=59165

Comment 2 Brian Pepple 2008-06-05 01:06:40 UTC
Good:
* Verified source tarball against git.
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* All necessary BuildRequires listed.
* Make succeeds.
* Files have appropriate permissions and owners

Bad:
* rpmlint produces the following error:
xorg-x11-drv-sunleo.sparc64: W: invalid-license MIT/X11

Looking at the license matrix, it looks like it should just be MIT.  You can fix
this when you import this into CVS.

Note: I don't have the hardware to verify that this driver works, but from a
packaging standpoint this package looks fine.

+1 APPROVE.

Comment 3 Dennis Gilmore 2008-06-06 04:29:04 UTC
Package Name: xorg-x11-drv-sunleo
Short Description: X driver for sunleo
Owners: ausil spot jima pjones
Branches: F-9
InitialCC:
Cvsextras Commits: yes

Comment 4 Dennis Gilmore 2008-06-06 21:43:17 UTC
imported and built  thanks for the review