Bug 448745
| Summary: | Review Request: ext3grep - Recovery tool for ext3 filesystems | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Milos Jakubicek <xjakub> |
| Component: | Package Review | Assignee: | Brian Pepple <bdpepple> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | bdpepple:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.6.0-1.fc9 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-06-03 07:30:51 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Milos Jakubicek
2008-05-28 15:26:23 UTC
MD5Sum:
aabd3b85e5862cddc284a37f300df186 ext3grep-0.6.0.tar.gz
Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Valid license tag
* Buildroot has all required elements
* All paths begin with macros
* All necessary BuildRequires listed.
* Make succeeds even when %{_smp_mflags} is defined
* Files have appropriate permissions and owners
* Rpmlint produces no warnings or errors
* Package builds fine in koji.
* Package installs and uninstalls cleanly
Minor (non-blocker):
* you should package the LICENSE.GPL2 file.
+1 Approved
(In reply to comment #1) > Minor (non-blocker): > * you should package the LICENSE.GPL2 file. Isn't this (as it is done now) the supposed way?: %doc NEWS README LICENSE.GPL2 > +1 Approved Thanks for your review. New Package CVS Request ======================= Package Name: ext3grep Short Description: Recovery tool for ext3 filesystems Owners: mjakubicek Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes cvs done. ext3grep-0.6.0-1.fc8 has been submitted as an update for Fedora 8 ext3grep-0.6.0-1.fc9 has been submitted as an update for Fedora 9 ext3grep-0.6.0-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. ext3grep-0.6.0-1.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. |