Bug 448745 - Review Request: ext3grep - Recovery tool for ext3 filesystems
Summary: Review Request: ext3grep - Recovery tool for ext3 filesystems
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Brian Pepple
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-05-28 15:26 UTC by Milos Jakubicek
Modified: 2008-06-03 07:33 UTC (History)
2 users (show)

Fixed In Version: 0.6.0-1.fc9
Clone Of:
Environment:
Last Closed: 2008-06-03 07:30:51 UTC
Type: ---
Embargoed:
bdpepple: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Milos Jakubicek 2008-05-28 15:26:23 UTC
Spec URL: http://mjakubicek.fedorapeople.org/ext3grep/ext3grep.spec
SRPM URL: http://mjakubicek.fedorapeople.org/ext3grep/ext3grep-0.6.0-1.fc9.src.rpm
Description: A tool to investigate an ext3 file system for deleted content and possibly recover it.

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=632237

Comment 1 Brian Pepple 2008-05-28 23:55:51 UTC
MD5Sum:
aabd3b85e5862cddc284a37f300df186  ext3grep-0.6.0.tar.gz

Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Valid license tag
* Buildroot has all required elements
* All paths begin with macros
* All necessary BuildRequires listed.
* Make succeeds even when %{_smp_mflags} is defined
* Files have appropriate permissions and owners
* Rpmlint produces no warnings or errors
* Package builds fine in koji.
* Package installs and uninstalls cleanly

Minor (non-blocker):
* you should package the LICENSE.GPL2 file.

+1 Approved

Comment 2 Milos Jakubicek 2008-05-29 06:46:11 UTC
(In reply to comment #1)
> Minor (non-blocker):
> * you should package the LICENSE.GPL2 file.

Isn't this (as it is done now) the supposed way?:

%doc NEWS README LICENSE.GPL2

> +1 Approved

Thanks for your review.

Comment 3 Milos Jakubicek 2008-05-29 13:48:58 UTC
New Package CVS Request
=======================
Package Name: ext3grep
Short Description: Recovery tool for ext3 filesystems
Owners: mjakubicek
Branches: F-8 F-9
InitialCC:
Cvsextras Commits: yes


Comment 4 Kevin Fenzi 2008-05-30 20:24:51 UTC
cvs done.

Comment 5 Fedora Update System 2008-05-31 20:12:52 UTC
ext3grep-0.6.0-1.fc8 has been submitted as an update for Fedora 8

Comment 6 Fedora Update System 2008-05-31 20:14:39 UTC
ext3grep-0.6.0-1.fc9 has been submitted as an update for Fedora 9

Comment 7 Fedora Update System 2008-06-03 07:30:49 UTC
ext3grep-0.6.0-1.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2008-06-03 07:33:01 UTC
ext3grep-0.6.0-1.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.