Bug 449234
| Summary: | Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bochecha, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://search.cpan.org/dist/Catalyst-Plugin-Session-State-Cookie/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-06-01 18:12:12 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 449251 | ||
|
Description
Chris Weyl
2008-05-31 19:13:40 UTC
Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=638376 + rpmlint is silent for SRPM but NOT for RPM. perl-Catalyst-Plugin-Session-State-Cookie.src:38: W: rpm-buildroot-usage %prep FOO=`perl -p -e 's|%{buildroot}%{_docdir}/%{name}-%{version}\S+||'` $RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it will break short circuiting. ==> I think this will not be a problem. + source files match upstream url 0eb184e081051ca284c2952ba6db59f7 Catalyst-Plugin-Session-State-Cookie-0.09.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs All tests successful. Files=5, Tests=32, 3 wallclock secs ( 1.16 cusr + 0.21 csys = 1.37 CPU) + Package perl-Catalyst-Plugin-Session-State-Cookie-0.09-1.fc10 => Provides: perl(Catalyst::Plugin::Session::State::Cookie) = 0.09 Requires: perl(:MODULE_COMPAT_5.10.0) perl(Catalyst::Plugin::Session) >= 0.19 perl(Catalyst::Utils) perl(NEXT) perl(base) perl(strict) perl(warnings) APPROVED. New Package CVS Request ======================= Package Name: perl-Catalyst-Plugin-Session-State-Cookie Short Description: Maintain session IDs using cookies Owners: cweyl Branches: F-7, F-8, F-9, devel InitialCC: perl-sig cvs done. (Except for F-7, as we are no longer doing F-7 branches.) Imported and built for rawhide. Thanks for the review! :) Package Change Request ====================== Package Name: perl-Catalyst-Plugin-Session-State-Cookie New Branches: el6 Owners: bochecha Chris doesn't maintain his packages in EPEL, but doesn't have a problem with others doing so. Git done (by process-git-requests). |