Bug 449251 - Review Request: perl-Catalyst-Plugin-Authentication - Infrastructure plugin for the Catalyst authentication framework
Summary: Review Request: perl-Catalyst-Plugin-Authentication - Infrastructure plugin f...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL: http://search.cpan.org/dist/Catalyst-...
Whiteboard:
Depends On: 449234
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-06-01 00:25 UTC by Chris Weyl
Modified: 2008-06-17 17:53 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-06-17 17:53:59 UTC
Type: ---
Embargoed:
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Chris Weyl 2008-06-01 00:25:53 UTC
SRPM URL: http://fedora.biggerontheinside.net/review/perl-Catalyst-Plugin-Authentication-0.10006-1.fc9.src.rpm
SPEC URL: http://fedora.biggerontheinside.net/review/perl-Catalyst-Plugin-Authentication.spec

Description:
The authentication plugin provides generic user support for Catalyst apps.
It is the basis for both authentication (checking the user is who they
claim to be), and authorization (allowing the user to do what the system
authorises them to do).

Comment 2 Parag AN(पराग) 2008-06-02 04:30:12 UTC
rpmlint output says

  
perl-Catalyst-Plugin-Authentication.src:42: W: rpm-buildroot-usage %prep
%{__perl_provides} `perl -p -e 's|%{buildroot}%{_docdir}/%{name}-%{version}\S+||'`
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.

perl-Catalyst-Plugin-Authentication.src:50: W: rpm-buildroot-usage %prep
%{__perl_requires} `perl -p -e 's|%{buildroot}%{_docdir}/%{name}-%{version}\S+||'`
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.


Also,
   Can you add POD test checking also?
t/pod..................
skipped
        all skipped: Test::Pod 1.14 required
t/pod_coverage.........
skipped
        all skipped: Test::Pod::Coverage 1.04 required
All tests successful, 2 tests skipped.


Comment 3 Chris Weyl 2008-06-03 05:07:06 UTC
(In reply to comment #2)
> rpmlint output says
> 
>   
> perl-Catalyst-Plugin-Authentication.src:42: W: rpm-buildroot-usage %prep
> %{__perl_provides} `perl -p -e 's|%{buildroot}%{_docdir}/%{name}-%{version}\S+||'`
> $RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
> will break short circuiting.
> 
> perl-Catalyst-Plugin-Authentication.src:50: W: rpm-buildroot-usage %prep
> %{__perl_requires} `perl -p -e 's|%{buildroot}%{_docdir}/%{name}-%{version}\S+||'`
> $RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
> will break short circuiting.

Addressed. 
 
> Also,
>    Can you add POD test checking also?
> t/pod..................
> skipped
>         all skipped: Test::Pod 1.14 required
> t/pod_coverage.........
> skipped
>         all skipped: Test::Pod::Coverage 1.04 required
> All tests successful, 2 tests skipped.

Pod tests are currently failing, so I'm allowing them to skip (not setting
TEST_POD=1).

SRPM URL:
http://fedora.biggerontheinside.net/review/perl-Catalyst-Plugin-Authentication-0.10006-2.fc9.src.rpm
SPEC URL:
http://fedora.biggerontheinside.net/review/perl-Catalyst-Plugin-Authentication.spec

Comment 4 Parag AN(पराग) 2008-06-12 04:30:17 UTC
sorry for late review. I was on vacation.
I am unable to download SRPM

Comment 5 Chris Weyl 2008-06-14 05:43:55 UTC
Odd, that.  Should be working now...

SRPM URL:
http://fedora.biggerontheinside.net/review/perl-Catalyst-Plugin-Authentication-0.10006-2.fc9.src.rpm


Comment 6 Parag AN(पराग) 2008-06-16 04:17:08 UTC
with above srpm I see tests failed so build also failed.
http://koji.fedoraproject.org/koji/taskinfo?taskID=663169

Comment 8 Parag AN(पराग) 2008-06-17 09:51:19 UTC
Review:
+ package builds in mock.
Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=664106
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
dbc176a55ba2b7ef2bfd0980f1772c50  Catalyst-Plugin-Authentication-0.10006.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test
All tests successful, 2 tests skipped.
Files=8, Tests=70,  2 wallclock secs ( 1.07 cusr +  0.08 csys =  1.15 CPU)
+ Package perl-Catalyst-Plugin-Authentication-0.10006-3.fc10 =>
Provides: perl(Catalyst::Authentication::Credential::Password)
perl(Catalyst::Authentication::Realm)
perl(Catalyst::Authentication::Realm::Compatibility)
perl(Catalyst::Authentication::Store::Minimal)
perl(Catalyst::Authentication::Store::Null) perl(Catalyst::Authentication::User)
perl(Catalyst::Authentication::User::Hash)
perl(Catalyst::Plugin::Authentication) = 0.10006
perl(Catalyst::Plugin::Authentication::Credential::Password)
perl(Catalyst::Plugin::Authentication::Store::Minimal)
perl(Catalyst::Plugin::Authentication::User)
perl(Catalyst::Plugin::Authentication::User::Hash)

Requires: perl(:MODULE_COMPAT_5.10.0) perl(Catalyst::Authentication::Realm)
perl(Catalyst::Authentication::User::Hash) perl(Catalyst::Exception)
perl(Catalyst::Plugin::Session) >= 0.10 perl(Catalyst::Runtime)
perl(Class::Inspector) perl(Digest) perl(Scalar::Util) perl(Tie::RefHash)
perl(base) perl(strict) perl(warnings)

APPROVED.


Comment 9 Chris Weyl 2008-06-17 16:04:14 UTC
New Package CVS Request
=======================
Package Name: perl-Catalyst-Plugin-Authentication
Short Description: Infrastructure plugin for the Catalyst authentication framework
Owners: cweyl
Branches: F-8, F-9, devel
InitialCC: perl-sig

Comment 10 Kevin Fenzi 2008-06-17 17:09:11 UTC
cvs done.

Comment 11 Chris Weyl 2008-06-17 17:53:59 UTC
Imported and building.  Thanks for the review! :)


Note You need to log in before you can comment on or make changes to this bug.