Bug 449251
| Summary: | Review Request: perl-Catalyst-Plugin-Authentication - Infrastructure plugin for the Catalyst authentication framework | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://search.cpan.org/dist/Catalyst-Plugin-Authentication/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-06-17 17:53:59 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 449234 | ||
| Bug Blocks: | |||
|
Description
Chris Weyl
2008-06-01 00:25:53 UTC
rpmlint output says
perl-Catalyst-Plugin-Authentication.src:42: W: rpm-buildroot-usage %prep
%{__perl_provides} `perl -p -e 's|%{buildroot}%{_docdir}/%{name}-%{version}\S+||'`
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.
perl-Catalyst-Plugin-Authentication.src:50: W: rpm-buildroot-usage %prep
%{__perl_requires} `perl -p -e 's|%{buildroot}%{_docdir}/%{name}-%{version}\S+||'`
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.
Also,
Can you add POD test checking also?
t/pod..................
skipped
all skipped: Test::Pod 1.14 required
t/pod_coverage.........
skipped
all skipped: Test::Pod::Coverage 1.04 required
All tests successful, 2 tests skipped.
(In reply to comment #2) > rpmlint output says > > > perl-Catalyst-Plugin-Authentication.src:42: W: rpm-buildroot-usage %prep > %{__perl_provides} `perl -p -e 's|%{buildroot}%{_docdir}/%{name}-%{version}\S+||'` > $RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it > will break short circuiting. > > perl-Catalyst-Plugin-Authentication.src:50: W: rpm-buildroot-usage %prep > %{__perl_requires} `perl -p -e 's|%{buildroot}%{_docdir}/%{name}-%{version}\S+||'` > $RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it > will break short circuiting. Addressed. > Also, > Can you add POD test checking also? > t/pod.................. > skipped > all skipped: Test::Pod 1.14 required > t/pod_coverage......... > skipped > all skipped: Test::Pod::Coverage 1.04 required > All tests successful, 2 tests skipped. Pod tests are currently failing, so I'm allowing them to skip (not setting TEST_POD=1). SRPM URL: http://fedora.biggerontheinside.net/review/perl-Catalyst-Plugin-Authentication-0.10006-2.fc9.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/perl-Catalyst-Plugin-Authentication.spec sorry for late review. I was on vacation. I am unable to download SRPM Odd, that. Should be working now... SRPM URL: http://fedora.biggerontheinside.net/review/perl-Catalyst-Plugin-Authentication-0.10006-2.fc9.src.rpm with above srpm I see tests failed so build also failed. http://koji.fedoraproject.org/koji/taskinfo?taskID=663169 Test::Exception added as a BR. (Note, also filed upstream as http://rt.cpan.org/Public/Bug/Display.html?id=36339) Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=664106 SRPM URL: http://fedora.biggerontheinside.net/review/perl-Catalyst-Plugin-Authentication-0.10006-3.fc8.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/perl-Catalyst-Plugin-Authentication.spec Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=664106 + rpmlint is silent for SRPM and for RPM. + source files match upstream url dbc176a55ba2b7ef2bfd0980f1772c50 Catalyst-Plugin-Authentication-0.10006.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test All tests successful, 2 tests skipped. Files=8, Tests=70, 2 wallclock secs ( 1.07 cusr + 0.08 csys = 1.15 CPU) + Package perl-Catalyst-Plugin-Authentication-0.10006-3.fc10 => Provides: perl(Catalyst::Authentication::Credential::Password) perl(Catalyst::Authentication::Realm) perl(Catalyst::Authentication::Realm::Compatibility) perl(Catalyst::Authentication::Store::Minimal) perl(Catalyst::Authentication::Store::Null) perl(Catalyst::Authentication::User) perl(Catalyst::Authentication::User::Hash) perl(Catalyst::Plugin::Authentication) = 0.10006 perl(Catalyst::Plugin::Authentication::Credential::Password) perl(Catalyst::Plugin::Authentication::Store::Minimal) perl(Catalyst::Plugin::Authentication::User) perl(Catalyst::Plugin::Authentication::User::Hash) Requires: perl(:MODULE_COMPAT_5.10.0) perl(Catalyst::Authentication::Realm) perl(Catalyst::Authentication::User::Hash) perl(Catalyst::Exception) perl(Catalyst::Plugin::Session) >= 0.10 perl(Catalyst::Runtime) perl(Class::Inspector) perl(Digest) perl(Scalar::Util) perl(Tie::RefHash) perl(base) perl(strict) perl(warnings) APPROVED. New Package CVS Request ======================= Package Name: perl-Catalyst-Plugin-Authentication Short Description: Infrastructure plugin for the Catalyst authentication framework Owners: cweyl Branches: F-8, F-9, devel InitialCC: perl-sig cvs done. Imported and building. Thanks for the review! :) |