Bug 449595
| Summary: | Review Request: gnome-applet-grandr - GNOME panel applet for XrandR | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Xavier Lamien <lxtnow> |
| Component: | Package Review | Assignee: | David Woodhouse <dwmw2> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | alex.smith.lx+rhbz, debarshir, dwmw2, fedora-package-review, notting, rhbugs, yaneti |
| Target Milestone: | --- | Flags: | dwmw2:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-05-13 14:43:15 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Xavier Lamien
2008-06-02 21:23:33 UTC
Perhaps you mean grandr-applet and URL: http://dekorte.homeip.net/download/grandr-applet/ Source0: http://dekorte.homeip.net/download/grandr-applet/grandr_applet-0.4.1.tar.gz yeah but, it's an addon package. So, the naming is correct for fedora inclusion. (In reply to comment #0) > + current rpmlint output: > E: zero-length /usr/share/doc/gnome-applet-grandr-0.4.1/NEWS > --> harmless. Remove the empty file. Ping? i'm still around. Actually, you can go ahead and o a full review if you wanted to. I'll make sure to remove that before cvs import. Aside from the zero-length file, please consider changing the description to reference Xorg instead of XFree86, although what it says at the moment _is_ technically correct. Please also consider fixing the email address in the specfile. Do you really think the spambots haven't learned to cope with [at] yet? You're only making hard for _real_ people, and not for the spammers. Other than that, it looks good. Approved. New Package Request ===================== Name: gnome-applet-grandr Short Description: Gnome interface to Subversion Owners: laxathom Branch: F-9 F-10 InitialCC: That description doesn't look right... Can you check it and reset the cvs flag when you are ready? ha! thanks Kevin. New Package Request ===================== Name: gnome-applet-grandr Short Description: GNOME panel applet for XrandR Owners: laxathom Branch: F-9 F-10 InitialCC: much better! ;) cvs done. |