Bug 449595 - Review Request: gnome-applet-grandr - GNOME panel applet for XrandR
Summary: Review Request: gnome-applet-grandr - GNOME panel applet for XrandR
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: David Woodhouse
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-06-02 21:23 UTC by Xavier Lamien
Modified: 2010-05-13 14:43 UTC (History)
7 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2010-05-13 14:43:15 UTC
Type: ---
Embargoed:
dwmw2: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Xavier Lamien 2008-06-02 21:23:33 UTC
Spec URL: http://laxathom.fedorapeople.org/RPMS/gnome-applet-grandr/gnome-applet-grandr.spec
SRPM URL: http://laxathom.fedorapeople.org/RPMS/gnome-applet-grandr/gnome-applet-grandr-0.4.1-1.fc8.src.rpm

Description:

GrandrApplet is a simple gnome-panel front end to the xrandr extension
found in XFree86 4.3+ releases.


+ current rpmlint output:
 E: zero-length /usr/share/doc/gnome-applet-grandr-0.4.1/NEWS
--> harmless.

Comment 1 Yanko Kaneti 2008-06-03 17:35:41 UTC
Perhaps you mean grandr-applet and

URL: http://dekorte.homeip.net/download/grandr-applet/
Source0: http://dekorte.homeip.net/download/grandr-applet/grandr_applet-0.4.1.tar.gz

Comment 2 Xavier Lamien 2008-06-04 13:00:38 UTC
yeah but, it's an addon package.
So, the naming is correct for fedora inclusion.

Comment 3 Debarshi Ray 2008-08-24 14:32:34 UTC
(In reply to comment #0)

> + current rpmlint output:
>  E: zero-length /usr/share/doc/gnome-applet-grandr-0.4.1/NEWS
> --> harmless.

Remove the empty file.

Comment 4 Debarshi Ray 2008-10-15 19:45:27 UTC
Ping?

Comment 5 Xavier Lamien 2008-11-20 00:13:16 UTC
i'm still around.
Actually, you can go ahead and o a full review if you wanted to.
I'll make sure to remove that before cvs import.

Comment 6 David Woodhouse 2008-11-20 00:42:31 UTC
Aside from the zero-length file, please consider changing the description to reference Xorg instead of XFree86, although what it says at the moment _is_ technically correct.

Please also consider fixing the email address in the specfile. Do you really think the spambots haven't learned to cope with [at] yet? You're only making hard for _real_ people, and not for the spammers.

Other than that, it looks good.

Approved.

Comment 7 Xavier Lamien 2008-12-21 03:18:17 UTC
New Package Request
=====================
Name:               gnome-applet-grandr
Short Description:  Gnome interface to Subversion
Owners:             laxathom
Branch:             F-9 F-10
InitialCC:

Comment 8 Kevin Fenzi 2008-12-21 03:53:26 UTC
That description doesn't look right...
Can you check it and reset the cvs flag when you are ready?

Comment 9 Xavier Lamien 2008-12-21 04:00:14 UTC
ha! thanks Kevin.


New Package Request
=====================
Name:               gnome-applet-grandr
Short Description:  GNOME panel applet for XrandR
Owners:             laxathom
Branch:             F-9 F-10
InitialCC:

Comment 10 Kevin Fenzi 2008-12-21 04:04:45 UTC
much better! ;) 

cvs done.


Note You need to log in before you can comment on or make changes to this bug.