Bug 449717
| Summary: | %check in rpm-spec comments kills rpm.specs | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ralf Corsepius <rc040203> |
| Component: | redhat-rpm-config | Assignee: | Jon Masters <jcm> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | 10 | CC: | alex, chris.ricker, cweyl, jnovy, j, matt_domsch, pmatilai, pnasrat, zing |
| Target Milestone: | --- | Keywords: | Reopened, Triaged |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-12-18 06:11:35 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 449419, 449485, 449500, 449544 | ||
|
Description
Ralf Corsepius
2008-06-03 03:17:48 UTC
This comes from redhat-rpm-config having added
%check %%check\
unset DISPLAY\
%{nil}
Despite looking like one, %check wasn't macro before but it is now, and macros
are expanded even in comments...
Overloading %check is foolishly naive, particularly since the %check script (like
every other build scriptlet) is templated exactly so that additional commands
can be added pre/post to spec file sections without the necessity to overload the
%check section marker.
Specifically, what could/should have been configured is
%__spec_check_pre unset DISPLAY;
Silly puppies gotta learn somehow I 'spose ...
Panu, I don't know if a separate BZ exists, but I guess you are aware about that rpmbuild >= FC10 also has killed %check ||: a construct, which some packagers apply to stay bugward compatible with ancient rpm versions. Ick. Let's invent syntax and randomly feed it to interpreters and pretend that we're programmers rather than script kiddies! Have fun! Reassigning to redhat-rpm-config which is where this trouble comes from - instead of overloading %prep, %build, %install and now %check, the build templates system should be used. Thanks Panu. Jeff's insightful comments aside, I didn't actually know %check wasn't internally a macro, so when the request came to override its behavior in the macros file, it seemed like a reasonable thing to do at the time. I'm on the fence about r-r-c in general - I own it because I needed to make some changes in the past and was the last one to touch it, but it might make more sense to hand it over to Panu, since you maintain the other version of the same macros/etc. that we are shipping and it would be nice to keep these things actually in sync. Jon. Jon: No offense intended. But r-r-c history goes way way way back .... ... to sopwith, a wonderful hacker with perhaps a twisted sense of humor who started the practice of overloading %foo section markers because it pleased his buildsys needs (AS 2.1 with ancient rpm in place). You dinna do more than follow pre-existing style as any professional does. Don't take the "puppies" comment personally ... builds as of 2008-07-03, version 9.0.3-1.fc10. reopening, should not have been closed by Matt. builds 2008-08-24 arrgg, re-opening. This bug appears to have been reported against 'rawhide' during the Fedora 10 development cycle. Changing version to '10'. More information and reason for this action is here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping This message is a reminder that Fedora 10 is nearing its end of life. Approximately 30 (thirty) days from now Fedora will stop maintaining and issuing updates for Fedora 10. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as WONTFIX if it remains open with a Fedora 'version' of '10'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version prior to Fedora 10's end of life. Bug Reporter: Thank you for reporting this issue and we are sorry that we may not be able to fix it before Fedora 10 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora please change the 'version' of this bug to the applicable version. If you are unable to change the version, please add a comment here and someone will do it for you. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. The process we are following is described here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping Fedora 10 changed to end-of-life (EOL) status on 2009-12-17. Fedora 10 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. Thank you for reporting this bug and we are sorry it could not be fixed. |