Bug 450470

Package can be found under

http://people.redhat.com/dledford/Infiniband/f10/noarch/

src rpm can be found under

http://people.redhat.com/dledford/Infiniband/f10/SRPMS/

Not necessarily *package* review comments:

- The udev in Fedora is new enough that you should be able to do add
--attr-match or --subsystem-match to your udevtrigger call so it doesn't cause a
retrigger of everything.
- Shouldn't those chipset errata be in PCI quirks (and the MTRR in DMI quirks)?

OK, I'll look into the match options with udev.

As for the chipset errata, I'll look into it.

As for the MTRR, I don't have anywhere near an exhaustive list of machines that
do this, and since it only shows up as bad performance on ib_ipath or on a
mmaped video frame buffer, I doubt I'm going to get an exhaustive list.  So, the
awk script works, and it's not tied to a list of machines, and it also allows
people to test if it helps since I wasn't 100% sure of the correctness of doing
this on all machines that punch out mtrr holes.

I've uploaded a new version of the package.  One of the pci errata things could
be done as a quirk (but isn't yet), the other I'm not so sure about as it would
require looking for a specific model and revision of hardware behind a specific
model of pci bridge and then applying the quirk, most of the kernel quirks don't
like being tied combinationally like that.  The udevtrigger line now works (and
what to match against is a bit obtuse, but I got it working and it now only does
a trigger on pci based devices with no driver and that are either class NETWORK
or INFINIBAND).

I built, installed, and tested this package on an F8 x86_64 system and it 
seems to work correctly.  I do *not* understand udev well enough to say  
whether the rules are correct but they do look reasonable -- esp. compared
the the OFED docs.

Here is a quick review:

GOOD:
+ rpmlint reports a few ignorable warnings and an error:
    rdma.noarch: W: no-documentation
    rdma.noarch: W: non-conffile-in-etc /etc/rdma/fixup-mtrr.awk
    rdma.noarch: W: non-conffile-in-etc /etc/udev/rules.d/90-rdma.rules
    rdma.noarch: W: no-url-tag
    rdma.noarch: E: malformed-line-in-lsb-comment-block #
+ naming looks OK
+ license is OK and correctly not included
+ spec is legible, macros look sane
+ compiles and installs on F8 x86_64
+ dir ownership looks OK

NEEDSWORK:
+ please remove the "blank" line which fixes the rpmlint error:

=== trivial patch ===
--- rdma.ORIG   2008-06-19 16:29:58.000000000 -0400
+++ rdma        2008-06-19 16:30:18.000000000 -0400
@@ -12,7 +12,6 @@
 # Required-Stop: $network $srpd $opensm
 # Short-Description: Loads and unloads the InfiniBand and iWARP kernel modules
 # Description: Loads and unloads the InfiniBand and iWARP kernel modules
-#
 ### END INIT INFO
 
 CONFIG=/etc/rdma/rdma.conf
=== trivial patch ===

New rpm uploaded over the top of the old rpm (meaning you might need to flush
your web cache/proxy to get the new rpm) that solves the rpmlint error (empty
line removed from rdma.init).

The package and the spec files seem good to me. Just the name rdma should be
replace by the macro %{name}.

I don't see any blockers here so its APPROVED.

And sorry for the delay responding!

Awesome.  I've updated the spec file to use the %{name} macro more, but since
this is a case where the package itself is the upstream source, no one should be
changing the name on us ;-)

New Package CVS Request
=======================
Package Name: rdma
Short Description: Infiniband/iWARP Kernel Module Initializer
Owners: dledford
Branches: F-8 F-9
InitialCC:
Cvsextras Commits: yes

cvs done.