Bug 451120
Summary: | Review Request: lua-lpeg - Parsing Expression Grammars for Lua | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Tim Niemueller <tim> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting |
Target Milestone: | --- | Flags: | j:
fedora-review+
j: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-08-01 21:26:04 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Tim Niemueller
2008-06-12 22:11:29 UTC
Builds fine and rpmlint is silent. I see two issues, one minor and one major. The minor one: the sed and chmod at the end of %install seem to me to make more sense in %prep. The major one: You need to be consistent about using macros like %{__cc}; you need to use %{__rm}, %{__mkdir}, %{__chmod} and %{__sed} instead. Or just use the non-macro forms everywhere. * source files match upstream: 8859c3dbd1d3dfd21c422362a66ad7c3c2c840fbbd47c7b806a5ba0c0013514a lpeg-0.8.1.tar.gz * package meets naming and versioning guidelines. * specfile is properly named and is cleanly written. X specfile does not use macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: lpeg.so.0.8.1()(64bit) lua-lpeg = 0.8.1-1.fc10 = lua >= 5.1 * %check is present and all tests pass. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. I've fixed both of these issues. New SRPM is at http://fedorapeople.org/~timn/luastuff/lua-lpeg-0.8.1-2.fc9.src.rpm. You almost got me there now, to obey the guidelines ;-) Thanks for the review, wanna hop on to bug #450527 or bug #450539 ? Still builds fine; the issues I had are fixed, although I admit that I can't figure out why anyone would prefer "%{__rm}" to "rm". In the end it's up to you. APPROVED I'll try to look at libkni; service-discovery-applet is a bit beyond my regular knowledge as I don't even run gnome. I used it because I didn't want to hardcode gcc but use %{__cc} instead. If I have to be consistent I'll rather use the macros for *this* package... Thanks for the review! New Package CVS Request ======================= Package Name: lua-lpeg Short Description: Parsing Expression Grammars for Lua Owners: timn Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes cvs done. Package Change Request ====================== Package Name: lua-lpeg New Branches: el5 el6 Owners: timn Git done (by process-git-requests). |