Bug 451120 - Review Request: lua-lpeg - Parsing Expression Grammars for Lua
Review Request: lua-lpeg - Parsing Expression Grammars for Lua
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jason Tibbitts
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-06-12 18:11 EDT by Tim Niemueller
Modified: 2010-11-07 10:40 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-08-01 17:26:04 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
tibbs: fedora‑review+
tibbs: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Tim Niemueller 2008-06-12 18:11:29 EDT
Spec URL: http://fedorapeople.org/~timn/luastuff/lua-lpeg.spec
SRPM URL: http://fedorapeople.org/~timn/luastuff/lua-lpeg-0.8.1-1.fc9.src.rpm
Description:
LPeg is a new pattern-matching library for Lua, based on Parsing Expression
Grammars (PEGs).

Website: http://www.inf.puc-rio.br/~roberto/lpeg.html
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=660005
(Changed summary after scratch build)
Comment 1 Jason Tibbitts 2008-06-12 19:49:12 EDT
Builds fine and rpmlint is silent.  I see two issues, one minor and one major.

The minor one: the sed and chmod at the end of %install seem to me to make more
sense in %prep.

The major one: You need to be consistent about using macros like %{__cc}; you
need to use %{__rm}, %{__mkdir}, %{__chmod} and %{__sed} instead.  Or just use
the non-macro forms everywhere.

* source files match upstream:
   8859c3dbd1d3dfd21c422362a66ad7c3c2c840fbbd47c7b806a5ba0c0013514a  
   lpeg-0.8.1.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named and is cleanly written.
X specfile does not use macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
   lpeg.so.0.8.1()(64bit)
   lua-lpeg = 0.8.1-1.fc10
  =
   lua >= 5.1

* %check is present and all tests pass.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.
Comment 2 Tim Niemueller 2008-06-13 04:19:37 EDT
I've fixed both of these issues. New SRPM is at
http://fedorapeople.org/~timn/luastuff/lua-lpeg-0.8.1-2.fc9.src.rpm.

You almost got me there now, to obey the guidelines ;-) Thanks for the review,
wanna hop on to bug #450527 or bug #450539 ?
Comment 3 Jason Tibbitts 2008-06-14 14:35:47 EDT
Still builds fine; the issues I had are fixed, although I admit that I can't
figure out why anyone would prefer "%{__rm}" to "rm".  In the end it's up to you.

APPROVED

I'll try to look at libkni; service-discovery-applet is a bit beyond my regular
 knowledge as I don't even run gnome.
Comment 4 Tim Niemueller 2008-06-16 04:11:00 EDT
I used it because I didn't want to hardcode gcc but use %{__cc} instead. If I
have to be consistent I'll rather use the macros for *this* package...

Thanks for the review!
Comment 5 Tim Niemueller 2008-06-16 04:12:14 EDT
New Package CVS Request
=======================
Package Name: lua-lpeg
Short Description: Parsing Expression Grammars for Lua
Owners: timn
Branches: F-8 F-9
InitialCC:
Cvsextras Commits: yes
Comment 6 Kevin Fenzi 2008-06-16 12:11:33 EDT
cvs done.
Comment 7 Tim Niemueller 2010-11-06 20:20:03 EDT
Package Change Request
======================
Package Name: lua-lpeg
New Branches: el5 el6
Owners: timn
Comment 8 Jason Tibbitts 2010-11-07 10:40:48 EST
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.