Bug 451142
| Summary: | Review Request: haddock09 - documentation tool for annotated Haskell source code | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Bryan O'Sullivan <bos> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, j, notting, petersen |
| Target Milestone: | --- | Flags: | j:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-06-19 01:51:52 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 451872 | ||
|
Description
Bryan O'Sullivan
2008-06-12 23:00:15 UTC
*bump* I pinged the selinux folks about the %post scriptlet and they indicated that that's definitely not the proper way to do things. For example, a relabel will render things inoperable. At minimum it's necessary to use semanage to add a context pattern and then use restorecon, but preferable that policy is updated to supply the proper context for that executable (or, of course, to fix things so that the special context isn't needed). https://www.redhat.com/archives/fedora-selinux-list/2008-June/msg00077.html OK, I've gotten rid of the %post script. I also cleaned up the spec file so that source and binary RPMs pass rpmlint, the thing is built with optimisation (!), and the generated binary is properly stripped (brp-strip doesn't touch the symbols). Spec: http://core.serpentine.com/haddock09.spec Patch0: http://core.serpentine.com/haddock-O2.patch SRPM: http://core.serpentine.com/haddock09-0.9-2.fc9.src.rpm I don't see any changes; the new package still has the same rpmlint complaints. Sorry, forgot to correct the release number in the SRPM after I cut and pasted. Here's the corrected link: http://core.serpentine.com/haddock09-0.9-3.fc9.src.rpm Oh, heh, browser caching. It seems odd to use the name of the package in the summary, since you get things like: haddock09 - Haddock documentation tool... but it's no big deal. Otherwise everything looks good to me. * source files match upstream: beefd4a6da577978e7a79cabba60970accc5cd48fbb04c424a6b36ace3a9f8d0 haddock-0.9.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: haddock09 = 0.9-3.fc10 = libgmp.so.3()(64bit) libutil.so.1()(64bit) * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. APPROVED Wonderful, thanks. I'll change the summary to something more sensible :-) Summary: Haskell documentation tool for annotated source code New Package CVS Request ======================= Package Name: haddock09 Short Description: Haskell documentation tool for annotated source code Owners: bos,petersen Branches: F-9 InitialCC: Cvsextras Commits: yes CVS done. Thanks for all the help, tibbs! |