Bug 451142 - Review Request: haddock09 - documentation tool for annotated Haskell source code
Review Request: haddock09 - documentation tool for annotated Haskell source code
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jason Tibbitts
Fedora Extras Quality Assurance
:
Depends On:
Blocks: 451872
  Show dependency treegraph
 
Reported: 2008-06-12 19:00 EDT by Bryan O'Sullivan
Modified: 2008-06-18 21:51 EDT (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-06-18 21:51:52 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
tibbs: fedora‑review+
tibbs: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Bryan O'Sullivan 2008-06-12 19:00:15 EDT
Spec URL: http://core.serpentine.com/haddock09.spec
SRPM URL: http://core.serpentine.com/haddock09-0.9-2.fc9.src.rpm
Description: 

Haddock is a tool for automatically generating hyperlinked documentation from
annotated Haskell source code.

We already package Haddock 2.0, but Haddock 0.9 is required for building GHC and a number of other Haskell packages.  This spec file is a revival of the last version of Haddock 0.9 that we packaged, in late 2007.  I have tweaked it minimally to fix up the naming.
Comment 1 Bryan O'Sullivan 2008-06-16 13:10:19 EDT
*bump*
Comment 2 Jason Tibbitts 2008-06-17 17:58:58 EDT
I pinged the selinux folks about the %post scriptlet and they indicated that
that's definitely not the proper way to do things.  For example, a relabel will
render things inoperable.  At minimum it's necessary to use semanage to add a
context pattern and then use restorecon, but preferable that policy is updated
to supply the proper context for that executable (or, of course, to fix things
so that the special context isn't needed).

https://www.redhat.com/archives/fedora-selinux-list/2008-June/msg00077.html
Comment 3 Bryan O'Sullivan 2008-06-17 19:33:53 EDT
OK, I've gotten rid of the %post script.  I also cleaned up the spec file so
that source and binary RPMs pass rpmlint, the thing is built with optimisation
(!), and the generated binary is properly stripped (brp-strip doesn't touch the
symbols).

Spec: http://core.serpentine.com/haddock09.spec
Patch0: http://core.serpentine.com/haddock-O2.patch
SRPM: http://core.serpentine.com/haddock09-0.9-2.fc9.src.rpm
Comment 4 Jason Tibbitts 2008-06-18 13:41:07 EDT
I don't see any changes; the new package still has the same rpmlint complaints.
Comment 5 Bryan O'Sullivan 2008-06-18 14:00:49 EDT
Sorry, forgot to correct the release number in the SRPM after I cut and pasted.

Here's the corrected link: http://core.serpentine.com/haddock09-0.9-3.fc9.src.rpm
Comment 6 Jason Tibbitts 2008-06-18 15:09:18 EDT
Oh, heh, browser caching.

It seems odd to use the name of the package in the summary, since you get things
like:
  haddock09 - Haddock documentation tool...
but it's no big deal.

Otherwise everything looks good to me.

* source files match upstream:
   beefd4a6da577978e7a79cabba60970accc5cd48fbb04c424a6b36ace3a9f8d0  
   haddock-0.9.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   haddock09 = 0.9-3.fc10
  =
   libgmp.so.3()(64bit)
   libutil.so.1()(64bit)

* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

APPROVED
Comment 7 Bryan O'Sullivan 2008-06-18 15:25:48 EDT
Wonderful, thanks. I'll change the summary to something more sensible :-)

Summary:        Haskell documentation tool for annotated source code
Comment 8 Bryan O'Sullivan 2008-06-18 15:29:23 EDT
New Package CVS Request
=======================
Package Name: haddock09
Short Description: Haskell documentation tool for annotated source code
Owners: bos,petersen
Branches: F-9
InitialCC:
Cvsextras Commits: yes
Comment 9 Jason Tibbitts 2008-06-18 20:47:24 EDT
CVS done.
Comment 10 Bryan O'Sullivan 2008-06-18 21:51:52 EDT
Thanks for all the help, tibbs!

Note You need to log in before you can comment on or make changes to this bug.