Bug 451587

Summary:	Review Request: sound-theme-freedesktop - the default sound theme for the X sound theming spec
Product:	[Fedora] Fedora	Reporter:	Lennart Poettering <lpoetter>
Component:	Package Review	Assignee:	Matthias Clasen <mclasen>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting
Target Milestone:	---	Flags:	mclasen: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-06-16 17:43:47 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Lennart Poettering 2008-06-16 02:04:23 UTC

Spec URL: http://0pointer.de/public/sound-theme-freedesktop.spec
SRPM URL: http://0pointer.de/public/sound-theme-freedesktop-0.1-1.fc10.src.rpm
Description: The default sound theme of the X sound theming spec

This is all kinds of sounds stolen from gnome-audio, KDE, Ekiga, Pidgin/Purple, ALSA, put together as XDG sound theme. This goes well along with libcanberra.

Licenses vary, the README lists them. Predominantly GPLv2.

Comment 1 Lennart Poettering 2008-06-16 02:06:28 UTC

Assigning to Mathias, since he already reviewed libcanberra (#450975) and this
package kind of belongs to libcanberra.

Comment 2 Matthias Clasen 2008-06-16 03:09:30 UTC

"Builds" fine in mock.rpmlint is silent.
I'll do a formal review in a bit, for now just this: you need to list all the
licenses in the license field, ideally with a comment that points to README for 
details what files each one covers.

Comment 3 Lennart Poettering 2008-06-16 13:08:54 UTC

Licenses are fixed now. spec and srpm are at the same place.

Comment 4 Matthias Clasen 2008-06-16 13:32:41 UTC

Formal review:

rpmlint is silent

package name: ok
spec file name: ok
packaging guidelines: ok
license: ok
license field: ok
license file: ok
spec file language: American English
spec file legibility: excellent
upstream sources: ok
buildable: yes
ExcludeArch: n/a
BuildRequires: ok
locale handling: ok
shared libs: ok
relocatable: n/a
directory ownership: ok, but I notice that /usr/share/sounds seems to be owned
by both alsa-utils and kde-filesystem. Might be worthwhile to move that to the
filesystem package, now that it is needed by yet another package. Can you
initiate that (ie file bugs) ?
duplicate filenames: ok
file permissions: ok
%clean: ok
macro use: consistent
content: permissible
large docs: n/a
%doc content: ok
headers: n/a
static libs: n/a
pc files: n/a
shared libs: n/a
devel package: n/a
libtool archives: n/a
gui apps: n/a
file ownership: ok
utf8 filenames: ok

Approved

Comment 5 Lennart Poettering 2008-06-16 13:40:01 UTC

New Package CVS Request
=======================
Package Name: sound-theme-freedesktop
Short Description: The default sound theme of the XDG sound theming spec
Owners: lennart
Branches: devel
InitialCC: 
Cvsextras Commits: yes

Comment 6 Kevin Fenzi 2008-06-16 16:20:29 UTC

cvs done.

Comment 7 Lennart Poettering 2008-06-16 17:43:47 UTC

Imported to CVS and built.