Red Hat Bugzilla – Bug 451587
Review Request: sound-theme-freedesktop - the default sound theme for the X sound theming spec
Last modified: 2008-06-16 13:43:47 EDT
Spec URL: http://0pointer.de/public/sound-theme-freedesktop.spec SRPM URL: http://0pointer.de/public/sound-theme-freedesktop-0.1-1.fc10.src.rpm Description: The default sound theme of the X sound theming spec This is all kinds of sounds stolen from gnome-audio, KDE, Ekiga, Pidgin/Purple, ALSA, put together as XDG sound theme. This goes well along with libcanberra. Licenses vary, the README lists them. Predominantly GPLv2.
Assigning to Mathias, since he already reviewed libcanberra (#450975) and this package kind of belongs to libcanberra.
"Builds" fine in mock.rpmlint is silent. I'll do a formal review in a bit, for now just this: you need to list all the licenses in the license field, ideally with a comment that points to README for details what files each one covers.
Licenses are fixed now. spec and srpm are at the same place.
Formal review: rpmlint is silent package name: ok spec file name: ok packaging guidelines: ok license: ok license field: ok license file: ok spec file language: American English spec file legibility: excellent upstream sources: ok buildable: yes ExcludeArch: n/a BuildRequires: ok locale handling: ok shared libs: ok relocatable: n/a directory ownership: ok, but I notice that /usr/share/sounds seems to be owned by both alsa-utils and kde-filesystem. Might be worthwhile to move that to the filesystem package, now that it is needed by yet another package. Can you initiate that (ie file bugs) ? duplicate filenames: ok file permissions: ok %clean: ok macro use: consistent content: permissible large docs: n/a %doc content: ok headers: n/a static libs: n/a pc files: n/a shared libs: n/a devel package: n/a libtool archives: n/a gui apps: n/a file ownership: ok utf8 filenames: ok Approved
New Package CVS Request ======================= Package Name: sound-theme-freedesktop Short Description: The default sound theme of the XDG sound theming spec Owners: lennart Branches: devel InitialCC: Cvsextras Commits: yes
cvs done.
Imported to CVS and built.