Bug 452172
| Summary: | Review Request: mysqltuner - MySQL high performance tuning script | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ville Skyttä <ville.skytta> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mhayden, notting, pahan |
| Target Milestone: | --- | Flags: | j:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-06-22 22:55:24 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Ville Skyttä
2008-06-19 19:56:59 UTC
This package is about as simple as you can get; a single file. I guess you know that's not what the dist tag is about, but I assume you can keep the versioning straight. Only one observation: The applied patch seems to be a good idea, except that if you actually pass the --skipversion option you are warned about it. Perhaps it would be better to accept and ignore it. I don't think this is a blocker, though, since things still run. * source files match upstream: 6d13fdfda710c5d1ef777a31177f31fb691af11a4f953e9fed07a6cdceff7a32 mysqltuner.pl.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper (none). * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint has acceptable complaints. * final provides and requires are sane: mysqltuner = 0.9.1-1 = /usr/bin/perl mysql perl(Getopt::Long) perl(diagnostics) perl(strict) perl(warnings) which * %check is not present; no test suite upstream. Seems to run OK, but I didn't let it mess with my database server. APPROVED Worked fine for me on mysql-4.1.20-3.RHEL4.1.el4_6.1 (Centos 4.6) and mysql-5.0.45-1.el5.remi.x86_64 (Centos 5.1) Thanks! I intend to maintain this for F-9+ and EL-5+; co-maintainers and maintainers for earlier branches are of course welcome. @tibbs: good catch wrt --skipversion, I'll adjust the patch before the first build. New Package CVS Request ======================= Package Name: mysqltuner Short Description: MySQL high performance tuning script Owners: scop Branches: F-9 EL-5 InitialCC: Cvsextras Commits: yes cvs done. I volunteer to maintain this for EL-4. Creating CVS request per Ville's approval in comment #3: Package Change Request ====================== Package Name: mysqltuner New Branches: EL-4 Updated Fedora CC: wolfy Updated EPEL Owners: wolfy mysqltuner-0.9.1-4 has been submitted as an update for Fedora 9 EL-5 and F-9+ builds succeeded, tweaking fedora-cvs flag so that admins notice comment 5. cvs done. mysqltuner-0.9.1-4 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. built in all branches. closing. Can I ask a build for F-8 too? I want use it on F-8. (In reply to comment #11) > Can I ask a build for F-8 too? I want use it on F-8. See comment 3. mysqltuner-0.9.1-4 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: mysqltuner New Branches: epel7 Owners: wolfy InitialCC: mhayden Git done (by process-git-requests). |