Bug 452172 - Review Request: mysqltuner - MySQL high performance tuning script
Review Request: mysqltuner - MySQL high performance tuning script
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jason Tibbitts
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-06-19 15:56 EDT by Ville Skyttä
Modified: 2014-12-03 10:10 EST (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-06-22 18:55:24 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
tibbs: fedora‑review+
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Ville Skyttä 2008-06-19 15:56:59 EDT
http://scop.fedorapeople.org/packages/mysqltuner.spec
http://scop.fedorapeople.org/packages/mysqltuner-0.9.1-1.src.rpm

MySQLTuner is a MySQL high performance tuning script written in perl
that will provide you with a snapshot of a MySQL server's health.
Based on the statistics gathered, specific recommendations will be
provided that will increase a MySQL server's efficiency and
performance.  The script gives you automated MySQL tuning that is on
the level of what you would receive from a MySQL DBA.

Note: intentionally not using %{?dist} as there's nothing really to build in the package that would change between rebuilds on different distros.
Comment 1 Jason Tibbitts 2008-06-19 21:44:20 EDT
This package is about as simple as you can get; a single file.

I guess you know that's not what the dist tag is about, but I assume you can
keep the versioning straight.

Only one observation:

The applied patch seems to be a good idea, except that if you actually pass the
--skipversion option you are warned about it.  Perhaps it would be better to
accept and ignore it.  I don't think this is a blocker, though, since things
still run.

* source files match upstream:
   6d13fdfda710c5d1ef777a31177f31fb691af11a4f953e9fed07a6cdceff7a32  
   mysqltuner.pl.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper (none).
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
   mysqltuner = 0.9.1-1
  =
   /usr/bin/perl
   mysql
   perl(Getopt::Long)
   perl(diagnostics)
   perl(strict)
   perl(warnings)
   which

* %check is not present; no test suite upstream.  Seems to run OK, but I didn't 
   let it mess with my database server.

APPROVED
Comment 2 manuel wolfshant 2008-06-20 03:30:06 EDT
Worked fine for me on mysql-4.1.20-3.RHEL4.1.el4_6.1 (Centos 4.6) and
mysql-5.0.45-1.el5.remi.x86_64 (Centos 5.1)
Comment 3 Ville Skyttä 2008-06-21 03:16:28 EDT
Thanks!  I intend to maintain this for F-9+ and EL-5+; co-maintainers and
maintainers for earlier branches are of course welcome.

@tibbs: good catch wrt --skipversion, I'll adjust the patch before the first build.

New Package CVS Request
=======================
Package Name: mysqltuner
Short Description: MySQL high performance tuning script
Owners: scop
Branches: F-9 EL-5
InitialCC:
Cvsextras Commits: yes
Comment 4 Kevin Fenzi 2008-06-21 11:29:49 EDT
cvs done.
Comment 5 manuel wolfshant 2008-06-21 11:42:58 EDT
I volunteer to maintain this for EL-4. Creating CVS request per Ville's approval
in comment #3:

Package Change Request
======================
Package Name: mysqltuner
New Branches: EL-4
Updated Fedora CC: wolfy
Updated EPEL Owners: wolfy
Comment 6 Fedora Update System 2008-06-21 14:36:16 EDT
mysqltuner-0.9.1-4 has been submitted as an update for Fedora 9
Comment 7 Ville Skyttä 2008-06-21 14:39:19 EDT
EL-5 and F-9+ builds succeeded, tweaking fedora-cvs flag so that admins notice
comment 5.
Comment 8 Kevin Fenzi 2008-06-22 11:58:00 EDT
cvs done.
Comment 9 Fedora Update System 2008-06-22 16:45:36 EDT
mysqltuner-0.9.1-4 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 10 manuel wolfshant 2008-06-22 18:55:24 EDT
built in all branches. closing.
Comment 11 Jan ONDREJ 2008-06-23 06:05:03 EDT
Can I ask a build for F-8 too? I want use it on F-8.
Comment 12 Ville Skyttä 2008-06-23 11:52:47 EDT
(In reply to comment #11)
> Can I ask a build for F-8 too? I want use it on F-8.

See comment 3.
Comment 13 Fedora Update System 2008-07-26 01:56:44 EDT
mysqltuner-0.9.1-4 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 14 manuel wolfshant 2014-12-03 09:22:12 EST
Package Change Request
======================
Package Name: mysqltuner
New Branches: epel7
Owners: wolfy
InitialCC: mhayden
Comment 15 Gwyn Ciesla 2014-12-03 10:09:43 EST
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.