Bug 452457
| Summary: | Review Request: perl-Crypt-CAST5_PP - CAST5 block cipher in pure Perl | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nigel Jones <dev> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mastahnke, notting |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.04-2.fc9 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-06-27 19:35:28 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 452450 | ||
|
Description
Nigel Jones
2008-06-23 04:02:09 UTC
Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=675953 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 563d7ecad9193fe442cf1fe0b1da1a97 Crypt-CAST5_PP-1.04.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful, 2 tests skipped. Files=3, Tests=8, 0 wallclock secs ( 0.08 cusr + 0.00 csys = 0.08 CPU) + Package perl-Crypt-CAST5_PP-1.04-1.fc10 => Provides: perl(Crypt::CAST5_PP) = 1.04 Requires: perl >= 0:5.004 perl(:MODULE_COMPAT_5.10.0) perl(AutoLoader) perl(Carp) perl(Test::More) >= 0.47 perl(integer) perl(strict) perl(vars) SHOULD: All tests should be successful. Check build.log from koji build and you will see t/2cbc...... skipped all skipped: Crypt::CBC required for this test t/3taint.... skipped all skipped: Test::Taint required for this test Spec URL: http://dev.nigelj.com/SRPMS/perl-Crypt-CAST5_PP.spec SRPM URL: http://dev.nigelj.com/SRPMS/perl-Crypt-CAST5_PP-1.04-2.fc9.src.rpm Fixed koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=675990 APPROVED. (In reply to comment #3) > koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=675990 > > APPROVED. Thanks New Package CVS Request ======================= Package Name: perl-Crypt-CAST5_PP Short Description: CAST5 block cipher in pure Perl Owners: nigelj Branches: F-8 F-9 EL-4 EL-5 InitialCC: perl-sig Cvsextras Commits: yes cvs done. *** Bug 452616 has been marked as a duplicate of this bug. *** perl-Crypt-CAST5_PP-1.04-2.fc9 has been submitted as an update for Fedora 9 perl-Crypt-CAST5_PP-1.04-2.fc8 has been submitted as an update for Fedora 8 perl-Crypt-CAST5_PP-1.04-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. perl-Crypt-CAST5_PP-1.04-2.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. |